Skip to content

fix: resolve DNS staging QA failures - #89

Merged
godsonten merged 1 commit into
mainfrom
issues/577-dns-qa-fixes
Oct 21, 2026
Merged

godsonten merged 1 commit into
mainfrom
issues/577-dns-qa-fixes

Conversation

@godsonten

@godsonten godsonten commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Live QA for zsoftly/iaas#785 found that deleting a multi-value DNS record set failed because the API requires the exact content of each value. Repeating a deletion also returned a server error, and unquoted CAA content reached the backend and failed there.

This change deletes each raw value from one initial snapshot, handles the verified DNS-specific absence response, and rejects unquoted CAA content locally with a quoted example. Concurrent additions are left alone. A partial failure returns an error without successful snapshot output. The existing SDK deletion method remains unchanged.

Validation: build, vet, staticcheck, full race-enabled tests, and independent code/context/content review passed. All five staging checks passed, including table/JSON/YAML snapshots, quoted CAA, local unquoted-CAA rejection, and repeated deletion. The disposable zone was deleted and the original zone list was restored.

Related: https://github.com/zsoftly/iaas/issues/785 and https://github.com/zsoftly/iaas/issues/762. Keep the parent open for release verification.

Companion documentation: zsoftly/zcp-docs#129.

Signed-off-by: godsonten <tendongze.g@zsoftly.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0c7298b6-9990-44d3-bfdc-db6ef94400fb
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ClintonChe ClintonChe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at 38e11e9 against main and the DNS QA scope in iaas #577/#762. No blocking issues found. Multi-value and idempotent deletion behavior, CAA validation, output semantics, focused tests, changelog, and command reference are consistent. Current required CI checks pass.

@godsonten
godsonten merged commit 4690440 into main Oct 21, 2026
22 checks passed
@godsonten godsonten changed the title fix: resolve DNS staging QA failures for iaas#577 fix: resolve DNS staging QA failures Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants