Repository navigation
fix: resolve DNS staging QA failures - #89
Merged
Merged
Conversation
Signed-off-by: godsonten <tendongze.g@zsoftly.com>
godsonten
requested review from
ClintonChe,
ditahkk and
ditahm6
as code owners
October 20, 2026 23:07
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ClintonChe
approved these changes
Oct 21, 2026
ClintonChe
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed at 38e11e9 against main and the DNS QA scope in iaas #577/#762. No blocking issues found. Multi-value and idempotent deletion behavior, CAA validation, output semantics, focused tests, changelog, and command reference are consistent. Current required CI checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live QA for zsoftly/iaas#785 found that deleting a multi-value DNS record set failed because the API requires the exact content of each value. Repeating a deletion also returned a server error, and unquoted CAA content reached the backend and failed there.
This change deletes each raw value from one initial snapshot, handles the verified DNS-specific absence response, and rejects unquoted CAA content locally with a quoted example. Concurrent additions are left alone. A partial failure returns an error without successful snapshot output. The existing SDK deletion method remains unchanged.
Validation: build, vet, staticcheck, full race-enabled tests, and independent code/context/content review passed. All five staging checks passed, including table/JSON/YAML snapshots, quoted CAA, local unquoted-CAA rejection, and repeated deletion. The disposable zone was deleted and the original zone list was restored.
Related: https://github.com/zsoftly/iaas/issues/785 and https://github.com/zsoftly/iaas/issues/762. Keep the parent open for release verification.
Companion documentation: zsoftly/zcp-docs#129.