Skip to content

fix: align DNS documentation with verified deletion behavior - #129

Merged
godsonten merged 3 commits into
mainfrom
issues/577-dns-qa-fixes
Oct 21, 2026
Merged

godsonten merged 3 commits into
mainfrom
issues/577-dns-qa-fixes

Conversation

@godsonten

@godsonten godsonten commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

What changed

Document content-specific API deletion in all four language examples, including raw MX priorities and TXT/CAA quotes. Explain that CLI deletion targets values from one initial snapshot, preserves concurrent additions, and reports partial failures. Clarify CAA quoting and the limited fallback when the initial lookup fails. Align the related record guide, troubleshooting page, and tutorial.

Why

Staging QA for https://github.com/zsoftly/iaas/issues/786 exposed incorrect assumptions about multi-value deletion. This accompanies the CLI fix and the retest recorded in https://github.com/zsoftly/iaas/issues/762.

Validation: changed-file formatting, lint, typecheck, all 31 documentation tests, and independent context/content review passed. Live API probes verified content-specific deletion for A, MX, TXT, and CAA. Full local formatting fails on the same four unchanged files as pristine main. The full build reports the same 66 invalid links in 33 files as pristine main, using the existing older installed dependencies (Astro 6.4.8 rather than declared 7.3.5). These are not introduced by this diff. Keep this PR draft until the declared dependency environment and full CI are verified. No dependency or unrelated page changes are included.

Companion CLI fix: zsoftly/zcp-cli#89.

CI update: formatting and type checking pass. The dependency audit fails on existing Vite 8.3.2 via Astro. The published advisory lists 8.3.3 as patched. CI skipped Build after the audit failed. Package and lock files are unchanged. Audit evidence: https://github.com/zsoftly/zcp-docs/actions/runs/39512892478. A maintainer must update the dependency and rerun the full checks before this draft is ready.

Signed-off-by: godsonten <tendongze.g@zsoftly.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 583ba8f7-9bd6-4e54-9371-a295f1aedb93
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@godsonten
godsonten marked this pull request as ready for review October 21, 2026 13:36
Signed-off-by: godsonten <tendongze.g@zsoftly.com>
fix: patch Vite dependency audit failure for #577

@ClintonChe ClintonChe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at 03c118b against main and the DNS QA scope in iaas #577/#762. No blocking issues found. DNS deletion examples and behavior match CLI #89, the Vite 8.3.3 override resolves the cited audit issue, and Lint, Type Check, Security Audit, and Build pass. Non-blocking: refresh the PR description because it still describes the earlier failed audit/draft state.

@godsonten
godsonten merged commit c60eafc into main Oct 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants