Repository navigation
fix: align DNS documentation with verified deletion behavior - #129
Merged
Merged
Conversation
Signed-off-by: godsonten <tendongze.g@zsoftly.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
godsonten
marked this pull request as ready for review
October 21, 2026 13:36
godsonten
requested review from
ClintonChe,
ditahkk and
ditahm6
as code owners
October 21, 2026 13:36
Signed-off-by: godsonten <tendongze.g@zsoftly.com>
fix: patch Vite dependency audit failure for #577
ClintonChe
approved these changes
Oct 21, 2026
ClintonChe
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed at 03c118b against main and the DNS QA scope in iaas #577/#762. No blocking issues found. DNS deletion examples and behavior match CLI #89, the Vite 8.3.3 override resolves the cited audit issue, and Lint, Type Check, Security Audit, and Build pass. Non-blocking: refresh the PR description because it still describes the earlier failed audit/draft state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Document content-specific API deletion in all four language examples, including raw MX priorities and TXT/CAA quotes. Explain that CLI deletion targets values from one initial snapshot, preserves concurrent additions, and reports partial failures. Clarify CAA quoting and the limited fallback when the initial lookup fails. Align the related record guide, troubleshooting page, and tutorial.
Why
Staging QA for https://github.com/zsoftly/iaas/issues/786 exposed incorrect assumptions about multi-value deletion. This accompanies the CLI fix and the retest recorded in https://github.com/zsoftly/iaas/issues/762.
Validation: changed-file formatting, lint, typecheck, all 31 documentation tests, and independent context/content review passed. Live API probes verified content-specific deletion for A, MX, TXT, and CAA. Full local formatting fails on the same four unchanged files as pristine main. The full build reports the same 66 invalid links in 33 files as pristine main, using the existing older installed dependencies (Astro 6.4.8 rather than declared 7.3.5). These are not introduced by this diff. Keep this PR draft until the declared dependency environment and full CI are verified. No dependency or unrelated page changes are included.
Companion CLI fix: zsoftly/zcp-cli#89.
CI update: formatting and type checking pass. The dependency audit fails on existing Vite 8.3.2 via Astro. The published advisory lists 8.3.3 as patched. CI skipped Build after the audit failed. Package and lock files are unchanged. Audit evidence: https://github.com/zsoftly/zcp-docs/actions/runs/39512892478. A maintainer must update the dependency and rerun the full checks before this draft is ready.