RUM-18189: Support new DSL for AGP 9 by kikoveiga · Pull Request #4060 · DataDog/dd-sdk-android

kikoveiga · 2026-10-28T15:04:20Z

What does this PR do?

Enable AGP 9's new DSL and built-in Kotlin, removing legacy opt-outs, the standalone Kotlin Android plugin, and RUM-18189 TODOs.
Upgrade Kotlin build tooling to 2.4.21, KSP to 2.3.12, Detekt to 2.0.0-alpha.6, and Apollo to 4.4.3; adapt code generation and fix compiler/static-analysis warnings and tests.
Retain binary-compatibility-validator with a built-in Kotlin adapter. Preserve automatic snapshot updates and run apiCheck before apiDump so API changes fail validation.
Preserve SQLDelight 1.5.5 integration compatibility by moving the sample's database generation into a separate JVM module.
Fix source API parsing and generated Kotlin source registration, including duplicate models in published sources JARs.

Motivation

Complete RUM-18189 by adopting AGP 9's build model while retaining SDK Kotlin 2.0 compatibility (language/API level 2.0 and stdlib 2.0.21).

Additional Notes

Detekt: alpha.1 requires the legacy Android setup. Alpha.3 added AGP 9 new DSL/built-in Kotlin support; alpha.6 includes subsequent fixes and Kotlin 2.4.10 analysis tooling, validated here with Kotlin 2.4.21.
Validation: library debug builds, formatting/Detekt, sources JAR inspection, all 214 build-logic tests, and generated-file checks passed locally. API-check regressions cover removed/unchanged APIs and automatic snapshot updates.

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

datadog-datadog-prod-us1-2 · 2026-10-28T15:14:17Z

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 25.97%
• Overall Coverage: 71.98% (-0.05%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 937c1df | Docs | View more details | Give us feedback!}

kikoveiga · 2026-10-28T17:35:27Z

@codex review

chatgpt-codex-connector · 2026-10-28T17:35:53Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-30T13:49:30.293776Z	`937c1df`	New commits
🔒 Security Review	✅ Completed 2026-10-30T13:48:48.858213Z	`937c1df`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector · 2026-10-28T17:39:12Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: a51fd05786

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

chatgpt-codex-connector · 2026-10-28T17:39:24Z

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: a51fd05786

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c379808ca6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

datadog-datadog-prod-us1-2

Release publication is blocked for modules with generated JSON models because their Kotlin files enter the source JAR twice, triggering AGP’s duplicate-entry failure.

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit c379808}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60be64e41f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

kikoveiga · 2026-10-29T16:09:01Z

@codex review

chatgpt-codex-connector · 2026-10-29T16:14:13Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 2a71b29a9e

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

chatgpt-codex-connector · 2026-10-29T16:14:22Z

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 2a71b29a9e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

kikoveiga force-pushed the kikoveiga/rum-18189/support-new-dsl branch from a7d08ac to 0e84980 Compare October 28, 2026 15:12

kikoveiga force-pushed the kikoveiga/rum-18189/support-new-dsl branch 4 times, most recently from 161c0a4 to a51fd05 Compare October 28, 2026 17:27

kikoveiga force-pushed the kikoveiga/rum-18189/support-new-dsl branch 2 times, most recently from e633b49 to c379808 Compare October 28, 2026 17:48

kikoveiga mentioned this pull request Oct 28, 2026

Fix feature registration test name collisions #4064

Merged

3 tasks

kikoveiga marked this pull request as ready for review October 28, 2026 18:09

kikoveiga requested review from a team as code owners October 28, 2026 18:09

kikoveiga added the ready-for-human-review All agentic review feedback was addressed and PR is ready for the human review. label Oct 28, 2026

chatgpt-codex-connector Bot reviewed Oct 28, 2026

View reviewed changes

Comment thread ...k-android-sqldelight/src/main/kotlin/com/datadog/android/sqldelight/DatadogSqliteCallback.kt Resolved

datadog-datadog-prod-us1-2 Bot reviewed Oct 28, 2026

View reviewed changes

Comment thread build-logic/src/main/kotlin/com/datadog/gradle/utils/JsonSchemaGenerationTasks.kt Resolved

maycmlee self-assigned this Oct 28, 2026

maycmlee previously approved these changes Oct 28, 2026

View reviewed changes

0xnm reviewed Oct 29, 2026

View reviewed changes

kikoveiga dismissed maycmlee’s stale review via d95a2ed October 29, 2026 14:10

kikoveiga force-pushed the kikoveiga/rum-18189/support-new-dsl branch 2 times, most recently from d95a2ed to 60be64e Compare October 29, 2026 15:26

chatgpt-codex-connector Bot reviewed Oct 29, 2026

View reviewed changes

Comment thread build-logic/src/main/kotlin/com/datadog/gradle/plugin/apisurface/BuiltInKotlinApiValidation.kt Resolved

kikoveiga force-pushed the kikoveiga/rum-18189/support-new-dsl branch from 60be64e to 2a71b29 Compare October 29, 2026 16:08

kikoveiga requested a review from 0xnm October 29, 2026 16:20

kikoveiga mentioned this pull request Oct 30, 2026

fix(android): preserve flushing before SDK shutdown DataDog/dd-sdk-flutter#1270

Merged

1 of 2 tasks

RUM-18189: Support new DSL for AGP 9

937c1df

kikoveiga force-pushed the kikoveiga/rum-18189/support-new-dsl branch from 2a71b29 to 937c1df Compare October 30, 2026 13:45

Conversation

kikoveiga commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Oct 28, 2026 • edited by datadog-official Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kikoveiga commented Oct 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026

🛡️ Codex Security Review · Automatically triggered

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

datadog-datadog-prod-us1-2 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

kikoveiga commented Oct 29, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 29, 2026

🛡️ Codex Security Review · Automatically triggered

Uh oh!

chatgpt-codex-connector Bot commented Oct 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kikoveiga commented Oct 28, 2026 •

edited

Loading

datadog-datadog-prod-us1-2 Bot commented Oct 28, 2026 •

edited by datadog-official Bot

Loading

chatgpt-codex-connector Bot commented Oct 28, 2026 •

edited

Loading