Repository navigation
build: upgrade Yarn 3.1 to 4.18 - #160
Merged
Merged
Conversation
- Replace bundled Yarn 3.1.0 release with 4.18.1 - Fix packageManager field, which incorrectly declared yarn@1.22.22 - Migrate yarn.lock to the v10 format (no version changes besides terser's optional acorn peer now being resolved) - Keep install scripts and the per-project cache enabled; adopt Yarn 4 defaults for git repo approval and the npm minimal age gate Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage 36.87% 36.87%
=======================================
Files 116 116
Lines 4301 4301
Branches 1038 1038
=======================================
Hits 1586 1586
Misses 2509 2509
Partials 206 206 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
EdgeTX Buddy has been automatically deployed to Cloudflare. |
The project uses Yarn; this npm lockfile was committed by accident in #134 and has drifted from yarn.lock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Yarn is the package manager and yarn.lock the source of truth. A stray package-lock.json (accidentally committed in #134) made tools pick npm, e.g. wrangler-action running `npm i` in the repo, and an `npm install` following it installs different versions than yarn.lock. Ignore it so a locally generated one can't be committed again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the bundled Yarn from 3.1.0 (2021) to 4.18.1. First step before bringing #136 (Electron) up to date, so the Electron PR only has to regenerate the lockfile once.
Changes
.yarn/releases/yarn-berry.cjs(3.1.0) →.yarn/releases/yarn-4.18.1.cjspackageManagernowyarn@4.18.1— it previously declaredyarn@1.22.22, which only worked because Yarn 1 defers toyarnPathyarn.lockmigrated from format v5 to v10. The diff is large but resolved versions are unchanged, apart fromacorn@8.19.0now being resolved as terser's optional peerpackage-lock.json(accidentally committed in feat: Backup and Restore for model and radio settings #134), and add it to.gitignoreso a locally generated one can't be committed again. It made lockfile-sniffing tools pick npm over Yarn, and annpm installfollowing it installs different versions thanyarn.lock..yarnrc.yml:enableScripts: true(electron, usb, esbuild, playwright need install scripts)enableGlobalCache: false,compressionLevel: 0)approvedGitRepositories(no git deps) andnpmMinimalAgeGate(1 day — only affects resolving newly published versions, not installs from the lockfile)Upgrading a local checkout
An existing
node_modulesfrom Yarn 3 can fail the install with an esbuild version mismatch. Deletenode_modulesand runyarnagain.Testing
Locally (Windows, Node 22):
yarn install --immutable,fmt:check,test:types,lint:all,compile:productionall pass.Unit tests show 28 Windows-only failures caused by the tests themselves (
execSync("node -e ...")quoting undercmd.exeinzipParser/backupspecs, and absoluteC:/paths in thesdcardsnapshot). CI runs unit tests on Linux, so these shouldn't appear here.Follow-ups
enableScripts: truewith a per-package allowlist (dependenciesMeta.<pkg>.built)🤖 Generated with Claude Code