Repository navigation
ci: pilot informational Python line and branch coverage (#651) - #662
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Fooftilly
temporarily deployed
to
project-automation
October 14, 2026 10:33 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
24 of 64 tasks
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 545ec6afd2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
First B1 informational coverage slice of #651. This adds a bounded Python line + branch coverage pilot without touching PRKS runtime, the PostgreSQL migration, or required Test Gate behavior.
.github/workflows/python-coverage-pilot.yml.tests/test_text_identity.pyvector suite; measure onlybackend/domain/text_identity.py.--fail-underthreshold. The targeted tests still need to pass, but low coverage does not fail CI..coverageis already gitignored; detailed JSON stays inRUNNER_TEMPand only aggregate counts appear in the job summary.workflow_dispatch. Stable existing checks remain unchanged; it does not run the full PRKS test suite a second time.Why separate instead of instrumenting the existing test gate?
The repository's test-gate invariants in
tests/test_dependency_gate.pyrequire exactlypython run_tests.pyand an allowlisted pinned install command. Rewriting it or adding extra execution steps for coverage would weaken well-established guards and add risk to ongoing PostgreSQL work. This isolated pilot collects actionable initial data cheaply. It does not purport to measure all Python modules, subprocess coverage, or changed-line coverage.Validation / acceptance
master@8d9e74fe25647fdf6560a3634935e27e43fafaa1.c197cf3: Python coverage pilot run 38550523559 passed, running all seven text-identity tests in 0.173 s. The job summary reports 16/16 executable lines (100.0%) and 6/6 branches (100.0%) for the one targeted module only. These figures are not repository-wide coverage.coverage json --outputoption; fixed inc197cf3by using documentedcoverage json -o. Rerun completed successfully.PRKS Test Gate,actionlintandzizmorchecks remain green; do not change required check names.Related: #651, #69, #624. No change to PostgreSQL runtime or parity-harness work.
Do not merge automatically. Leave open for maintainer review and approval.