Repository navigation
ci: pilot informational Vitest coverage for tab-leave decisions (#651) - #664
Merged
Merged
Conversation
Fooftilly
temporarily deployed
to
project-automation
October 14, 2026 11:24 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
24 of 64 tasks
Fooftilly
commented
Oct 14, 2026
Fooftilly
left a comment
Owner
Author
There was a problem hiding this comment.
One finding on the provider install step (inline). The pilot itself ran and produced real totals (12 tests passed; Lines 77/94, 81.9%; Branches 53/84, 63.1%).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second B1 informational coverage slice under #651, following the merged Python coverage pilot #662.
Adds one path-scoped GitHub Actions workflow to measure line and branch coverage for
frontend-app/src/lifecycle/tab-leave.tsusing its existingtab-leave.test.tsVitest suite. This module implements owner freshness, cancellation/rejection, flush and commit ordering, and batch atomicity; it is more safety-critical than UI rendering/style code.Design
frontend-app/package-lock.jsonand@vitest/coverage-v8@5.0.2, matching the pinned version exactly.@vitest/coverage-v8@5.0.2as a pinned development-only dependency infrontend-app/package.json, its generated npm lockfile, and the accepteddependency-inventory.json(required by PRKS's dependency preflight), matchingvitest@5.0.2. CI installs everything with onlynpm ci --ignore-scripts; no ad-hoc installation, unpinned package, production dependency, or generated bundle is introduced. This addresses the zizmorunlocked-installfinding and Codex's unlocked-transitive-dependency finding on the initial pilot.src/lifecycle/tab-leave.test.tssuite with V8 coverage, restricting the report tosrc/lifecycle/tab-leave.ts. It does not rerun all frontend tests or modify the main Vue CI job.covered/totalvalues and percentages to the GitHub Actions job summary;json-summarystays inRUNNER_TEMP, never uploaded. Validates both denominators are nonzero to prevent falsely reporting an empty pilot.fail-under, PR comments, or coverage artifact uploads. Failing tests or a broken reporter still fail the pilot job.workflow_dispatchis also supported. Minimal read-only permissions, pinned checkout/setup-node action SHAs, Node version consistent with the main Vue check.Validation / acceptance
master@104e1499f74b5522f8795fad906a731367a20f0d(merge of ci: pilot informational Python line and branch coverage (#651) #662).tab-leave.tsonly. The final head782bacahas now passed all eight GitHub Actions workflows, including the inventory-enforcing PRKS Test Gate, static analysis, CodeQL, actionlint, zizmor, Dependency Review, the Vitest pilot, and the Full E2E Gate. The original E2E attempt failed once on a Work Reminders Playwright wait; failed-job rerun (attempt 2) passed all six E2E shards, including the previously failing test. No unrelated product changes were made.Scope: One new workflow plus one pinned dev dependency, its npm lockfile and the required dependency inventory entry; no runtime, PostgreSQL, offline-state, or existing CI gate changes. No automatic merge; leave open for maintainer approval.
Related: #651 (B1), #662, and tab leave ownership #233.