Repository navigation
C2: delete the kernel egress engine; the connector is the one outbound path (supersedes #1230) - #1656
Merged
Merged
Conversation
…ctor's (supersedes #1230) Carries #1230's deletion onto current dev: busbar-kernel/src/egress/engine/, egress/fixtures.rs, secure.rs, PinnedClientPool, topology's UpstreamClients, the engine-only egress/trust primitives, and the kernel's reqwest/hyper/rcgen edges. The proxied mTLS fixture serves the plain carrier the sec door rides; topology/worker_shard_tests.rs now pins the surviving worker_stripe behaviour.
Collaborator
Author
|
Resolved: |
# Conflicts: # crates/busbar-kernel/Cargo.toml
# Conflicts: # crates/busbar-kernel/src/egress/trust/mod.rs # crates/busbar-kernel/src/secure.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO section D, item C2 (deletion moved up, owner ruling). This deletes the kernel's outbound HTTP engine, so the connector's dial is now the only outbound path.
Relation to #1230: none of #1230 had landed on dev. This PR carries #1230's content, squashed onto current dev, plus fixes for the three tests that were red on #1230. This PR supersedes #1230.
Deleted:
busbar-kernel/src/egress/engine/(client, pool, https, tls, CONNECT tunnel, observe, resolve, deadline) and its testsegress/fixtures.rs,secure.rs,PinnedClientPool, topology'sUpstreamClientsegress/trustprimitives only the engine readreqwest/hyper/hyper-util/rcgenedges, and reqwest'sh2edge in Cargo.lockUrlUserinfomoves tobound_credential. The proxy env now goes only to the connector. The kernel'stests/no_socket.rspins are empty.Fixes on top of #1230:
transport_pin::a_proxied_dial_tunnels_first_then_presents_the_sealed_identity_over_tls: the fixture served noplaincarrier for thesecdoor to ride, soopenrefused before dialing. The fixture now serves the same two transports as its non-proxied siblingtrusting. No assertion changed.no_silent_skip: itsMUST_COVERnamedsrc/topology/worker_shard_tests.rs, which row 130 E5+E7: the kernel's outbound HTTP engine leaves busbar-kernel; the no-socket pin is empty #1230 deleted. That file now holds a behaviour test of the survivingworker_stripelogic (distinct stripes per worker, out-of-range ids clamp, unset ids fall back). The gate is unchanged.door_steps::tests::spent_ledger::a_second_fleet_node_cannot_redeem_...: passes locally on this tree. No change.Touching another lane: the only edit in
busbar-kernel/src/proxy/mod.rs(step 5's area) is removing the engine re-exports and thebuild_egress_clientshim, which cannot outlive the engine.Production LOC (non-blank, non-comment
.rs, tests excluded, the section D method): 257,165 on dev → 253,985 (−3,180).