Repository navigation
Add returning() to inserts on Postgres - #10
Merged
Merged
Conversation
returning takes column names or a callback, as select does. The row schema is derived from the list, so Database.run decodes the inserted rows; an untyped expression leaves it undecoded and names the alias. CompiledQuery.returning lists the aliases, which run reads to pick the row path over the command path, so a precompiled insert runs correctly. DialectClauses.returning is optional (absent means no). Postgres sets it; on ClickHouse, returning is a defect at compile, like format() on Postgres. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of
design/writes.md. Stacked on #9; review that first.What changes
returningtakes column names or a callback, the same two forms asselect. Calling it again replaces the list.runreturns decoded rows. AnuntypedExpr(such as Maple'spg_current_xact_id()::xid::text) leaves the insert undecoded, withrowSchemaSource: "none"and the alias inuntypedColumns.CompiledQuery.returninglists the aliases.runreads it to choose between the row path and the command path, so a precompiled insert also runs correctly.DialectClauses.returning(absent means no). Postgres sets it. On ClickHouse,returningis aQueryBuilderDefectat compile, the same as.format()on Postgres.Testing
bun run typecheckandbun run test: 497 unit tests and the doc checks pass.RowOf.returningand checks the decoded defaults (uses,revoked,created_at).🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.