Repository navigation
Conversation
…nly the first The awk splitter ended each section with print buf "\x01", and print appends a newline after the delimiter. Every section after the first therefore began with an empty line, read an empty heading and was skipped, so each bug-log file drafted one entry. It now uses printf "%s\x01", buf. Test: tests/wave2/test-harvest-learnings.sh T5 runs on a two-file fixture (5 and 2 sections) that keeps the structure of a captured field log, with its text replaced (see the fixture's CAPTURE.md). T5 expects all 7 sections to be drafted and a heading the toolkit log already carries to be filtered out. Run against origin/master 393d253: with master's bin/harvest-learnings.sh the fixture passes 18 of 20 checks and T5 fails (2 of 7 sections drafted); with the fixed script it passes 20 of 20. Field run, a Mendix 10.24 app with mxcli v0.27.0 (43 bug-log files, 54 '## ' sections): the script at 393d253 drafts 43, the fix drafts 54. The splitter's delimiter bytes were checked under macOS awk 20200816 only.
Owner
|
Thanks @saingge! Independent review: MERGE. We moved your commit unchanged, with your authorship, into #553, so CI runs without fork approval and we can handle CHANGELOG conflicts. This PR closes when #553 merges; the merge commit carries a Co-authored-by line for you. Generated by Claude Code |
MendixMau
added a commit
that referenced
this pull request
Oct 22, 2026
…nly the first (#553, from #527) The awk splitter ended each section with print buf "\x01", which appends a newline, so every section after the first read an empty heading and was skipped. It now uses printf "%s\x01", buf. Fixture test-harvest-learnings.sh T5 (7 of 7 sections drafted). Field run: 54 vs 43 drafts on one app. Contributed by @saingge in #527. Review: MERGE — real one-line awk fix; T5 10/10. Security review: safe. Co-authored-by: saingge <262679532+saingge@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
fix/harvest-multi-entry, one commit on origin/master 393d253. Lane 3 (direct).What changed and why
bin/harvest-learnings.shsection 1 splits eachbug-logs/*.mdfile on its##headings withawk. The splitter ended each section with
print buf "\x01", andprintappends a newline afterthe delimiter. Every section after the first therefore began with an empty line, read an empty
heading and was skipped, so each bug-log file drafted one entry. It is
printf "%s\x01", bufnow. T5 in
tests/wave2/test-harvest-learnings.shpins it on a two-file fixture.Impact
bin/harvest-learnings.shand its own fixture only. No shared file, no new tool, no new artifact read.Field evidence
A Mendix 10.24 app, mxcli v0.27.0, 43 bug-log files holding 54
##sections. The script at393d253 drafts 43 (one per file); the fixed script drafts 54. Run with
--toa scratch directory,so nothing was written to the project or the toolkit.
Checklist
LEAKGUARD_BASE=origin/master, then a read of the diff).test-harvest-learnings.sh, plus the T2 field run above.>status blocks, a fenced block, a non-bug section, the last section ending in one newline). Only the text was replaced;CAPTURE.mdsays so.bug-logs/under it.\n \001, then\001). Not run under mawk, BusyBox awk or Git Bash.printf "%s\x01"is plain awk, but that is not tested here.## Unreleased, credited.Verification
Run in a clone of master at 393d253 and in this branch.