Repository navigation
fix(harvest-learnings): draft every '## ' section of a bug log, not only the first (replaces #527) - #553
Merged
Conversation
…nly the first The awk splitter ended each section with print buf "\x01", and print appends a newline after the delimiter. Every section after the first therefore began with an empty line, read an empty heading and was skipped, so each bug-log file drafted one entry. It now uses printf "%s\x01", buf. Test: tests/wave2/test-harvest-learnings.sh T5 runs on a two-file fixture (5 and 2 sections) that keeps the structure of a captured field log, with its text replaced (see the fixture's CAPTURE.md). T5 expects all 7 sections to be drafted and a heading the toolkit log already carries to be filtered out. Run against origin/master 393d253: with master's bin/harvest-learnings.sh the fixture passes 18 of 20 checks and T5 fails (2 of 7 sections drafted); with the fixed script it passes 20 of 20. Field run, a Mendix 10.24 app with mxcli v0.27.0 (43 bug-log files, 54 '## ' sections): the script at 393d253 drafts 43, the fix drafts 54. The splitter's delimiter bytes were checked under macOS awk 20200816 only.
5 of 7 tasks
…eep both sides) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013jQvaonym9V1wKKfAEPmRr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #527 by @saingge. Their commit 0c4dc18 is carried unchanged, with their authorship. It moved into our repo so CI runs without fork approval and CHANGELOG conflicts can be resolved here. See #527 for the full description and evidence.
Review: MERGE (independent review: real one-line awk fix; T5 10/10). Security review: safe.
Generated by Claude Code