Repository navigation
Conversation
… tika, infinispan, snmp, jdbc, jsch, micrometer - bug fixes CAMEL-25924 kafka: only a JSON array is split, for Jackson 2 and 3 CAMEL-25938 ftp, ftps, sftp, mina-sftp, azure-files, smb: the default of download is true in the catalog CAMEL-25977 dns: dig defaults to type A and needs a name; wikipedia is deprecated CAMEL-26052 as2: client/send sends bytes and files, fails on an HTTP error, requestUri default, ediMessageType deprecated, quoted-printable, logging CAMEL-26053 graphql: the request headers of the producer win and do not stay on the message; Map bodies CAMEL-26058 vertx-http: Path and Reader bodies, decoded urlencoded forms CAMEL-25983 github2: getCommitFile reads the file of the commit CAMEL-26054 pdf: pageSize values, extractText after create, line ends, no body, Path files to merge CAMEL-26057 tika: a body that is not a stream fails clearly; the charset of the output CAMEL-25976 infinispan-embedded: the configurationUri reads files and placeholders CAMEL-26055 snmp: GET without type, trap body, SnmpMessage to String, the poll consumer CAMEL-26056 jdbc: outputClass not found, generated keys, no body, docs CAMEL-26059 jsch: scp without a known hosts file; the remote directory must exist CAMEL-26061 micrometer: the docs say a failure fails the exchange Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
github-actions
Bot
added
components
components-kafka
catalog
docs
dsl
components-azure
labels
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
gnodet-bot
reviewed
Oct 23, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
Contributor
There was a problem hiding this comment.
Broad, well-tested bug-fix PR touching 14+ components. Changes are correct and well-motivated. Two low-severity issues found.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
The quoted-printable stream closes the underlying stream also when the write fails, and the GraphQL variables of a Map copy its keys as text instead of an unchecked cast. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Contributor
✅ Generated files are up to dateAn earlier CI run reported uncommitted generated changes; the latest run no longer does. |
gnodet-bot
reviewed
Oct 23, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
Contributor
There was a problem hiding this comment.
All three low-severity findings from the previous review have been verified against the current diff:
-
QuotedPrintableOutputStream
flush()gap (camel-as2): Confirmed — the class buffers all writes into aByteArrayOutputStreamand only flushes encoded content inclose(). The inheritedFilterOutputStream.flush()is a no-op on the buffered data. Low-severity design note; no correctness issue for standard use. -
URLDecoder.decodeon malformed percent sequences (camel-vertx-http): Confirmed — the newparseForm()helper callsURLDecoder.decode()directly, which throwsIllegalArgumentExceptionon invalid sequences like%ZZ, unlike the previousURISupport.parseQuerypath. Low-severity behavioral difference worth noting for edge cases. -
Infinispan
InputStreamresource leak fix (camel-infinispan-embedded): Confirmed — the new try-with-resources correctly closes theInputStreampassed toDefaultCacheManager. This is a positive fix.
No blocking issues. ✅
This review was generated by an AI agent, Hermès on behalf of @gnodet.
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 45 of 707 tested, 1 compile-only — current: 45 all testedMaveniverse Scalpel detected 45 affected modules (current approach: 45). Skip-tests mode would test 45 modules (24 direct + 0 downstream), skip tests for 1 (generated code, meta-modules) Modules Scalpel would test (45)
Modules with tests skipped (1)
Build reactor — dependencies compiled but only changed modules were tested (24 modules, 4m 57s total)Total reactor time: 4m 57s
Top 20 slowest modules:
|
…odedContent on purpose Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
gnodet-bot
reviewed
Oct 24, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
Contributor
There was a problem hiding this comment.
Following up on my earlier reviews — the previous findings are all addressed:
QuotedPrintableOutputStream.close()resource leak — ✅ fixed withtry/finallyin 48bb5fbGraphqlProducerunchecked cast — ✅ fixed via key-stringification in 48bb5fb
The new commit (3856e7e) adds @SuppressWarnings("deprecation") on readContent() in GetCommitFileProducer. The suppression is correctly scoped to the method and the use of file.getEncodedContent() is intentional: the raw base64 string is needed for the MIME decoder to handle GitHub's line-wrapped encoding; the blob API already covers the > 1 MB path. No issues.
LGTM.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
This was referenced Oct 24, 2026
Main's new body type text is updated where this PR changes the behavior it describes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
davsclaus
added a commit
that referenced
this pull request
Oct 24, 2026
… tika, infinispan, snmp, jdbc, jsch, micrometer - bug fixes (#28373) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Contributor
Author
|
Merged to main as 27158e7 (squashed together with the other body type bug batches, tested together locally). Claude Code on behalf of davsclaus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Code on behalf of davsclaus
Bug fixes for fourteen components, found while adding the catalog body types (CAMEL-24961). One commit; every behaviour fix has a unit test that failed before it.
useIterator, only a JSON array node is split (Jackson 2 and Jackson 3, the latter by class name); an object node and a scalar node are one recorddownloadistrue(ftp, ftps, sftp, mina-sftp, azure-files, smb)wikipediatype is deprecatedrequestUridefaults to/;ediMessageTypedeprecated (and used as the content type when it is the only one set); quoted-printable really encoded; no ERROR log for unencrypted messages or a closed async MDN connection; docsCamelGitHubCommitSha, path from the newCamelGitHubFilePathheader or the body), with the MIME base64 decoderpageSizevalues work (A4 gave Letter); extractText after create; CR LF, CR and tabs with lineTermination; create without a body fails clearly; Path elements for merge; the tests now assertgetMandatoryBodyfor detect and parse; parse sets the exchange charset to the output encodingconfigurationUrireadsfile:, absolute paths and placeholders; docs say which options are component-onlygetMandatoryBody;SnmpMessageconverts to String; the poll consumer uses a new PDU per poll and counts its polls; docsgetMandatoryBodyfor the SQL;transacteddeprecated (never read); docsstrictHostKeyCheckingdecides, unchanged); docs say the remote directory must existmetricsTypedefaults to counterBehaviour changes are in the 4.24 upgrade guide; the main ones: kafka sends a JSON object node as one record (the 4.22 guide said they are split), as2 client/send fails on a non-2xx answer, graphql no longer leaves
CamelHttpMethodon the message, jdbc generated keys ignoreoutputClass.Not in this PR: CAMEL-26060 (file-watch) has a contributor PR (#28361). The as2 changes stay out of the code that #28331, #28265 and #28362 change.
Catalog JSON and docs copied, endpoint and component DSLs regenerated. Main only, except the camel-github2 fix (CAMEL-25983): it is also backported to camel-4.18.x and camel-4.22.x, so its upgrade note is in the 4.18.6 and 4.22.3 sections of those guides too.
🤖 Generated with Claude Code