Repository navigation
Wait up to 5.5 hours for reviewer-approved publishes before the GitHub Release - #201
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df059d2ada
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Release secrets and the per-registry environments This repository publishes from one environment per registry:
No secret needs to move into them, so there is nothing to rotate in here. Each publish authenticates with OIDC trusted publishing (the package registries) or If a registry ever needs a token, put it in that registry's environment, not at repository level, and use the same order the other repositories follow:
Each registry's trusted publisher should also name its environment (for example |
…side the token's quota Six filename-based gh run list calls every 30s cost ~1,440 requests an hour against GITHUB_TOKEN's 1,000, ending the wait at ~40 minutes. List the commit's runs once per poll and match each workflow by path, and let a transient listing error retry next poll instead of ending the job.
df059d2 to
0605cbc
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0605cbc82a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
GitHub documents workflow_runs[].path as possibly ref-qualified (.github/workflows/build.yml@main); strip it before comparing.
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
release-githubnow waits up to 5.5 hours for the registry publishes, instead of 30 minutes, because each publish now waits for a reviewer.Why: every registry publish (RubyGems, npm, crates, GitHub Packages and the Go module tag) runs in its own environment, and those environments now require approval from sip or cli. A 30-minute wait would fail the GitHub Release before reviewers got to them.
Releasing now: push the
v*tag as before. Each language's workflow then waits at its publish job:release-githubneeds no approval of its own. It creates the notes-only GitHub Release once every publish run for the tag has succeeded. A rejected or unanswered publish fails it. If approvals take longer than 5.5 hours, re-run it withgh workflow run release-github.yml -f tag=vX.Y.Z.Who approves: a member of sip or cli. Prevent-self-review is on, so whoever pushed the tag can't approve their own release; another member does.
To approve every waiting run for a tag in one pass (GitHub still records one approval per run):
Run it again if a build finishes after the first pass.
Environment: all five environments already exist, require sip or cli, and admit only
v*tags. Nothing else needs configuring when this merges.Merging is the owners' call.
Summary by cubic
Updates the
release-githubworkflow to wait up to 5.5 hours for reviewer-approved registry publishes before creating the GitHub Release, instead of 30 minutes. Each registry publish (RubyGems, npm, crates, GitHub Packages, and the Go module tag) now requires an approval from a sip or cli member, so the old timeout was too short. If approvals take longer than 5.5 hours, rerun the workflow with the tag.The wait now lists each commit's runs with one API request per poll instead of six, keeping it inside
GITHUB_TOKEN's 1,000 requests/hour quota; a transient listing error retries on the next poll instead of ending the job. Workflow runs are matched by path whether it carries a ref suffix or not.Written for commit 8896f5e. Summary will update on new commits.