Skip to content

test(e2e): reveal the stacked player before opening a transcript - #495

Merged
chhoumann merged 1 commit into
masterfrom
test/stacked-transcript-reveal
Oct 15, 2026
Merged

chhoumann merged 1 commit into
masterfrom
test/stacked-transcript-reveal

Conversation

@chhoumann

@chhoumann chhoumann commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

Fixes #491

The stacked-transcript journey sometimes asked for Open note after Obsidian had hidden the player. Fast isolated runs passed because the click helper's automatic scrolling interrupted Obsidian's animation and pulled the player back into view.

Wait for the player to hide, then click its visible stacked-tab spine before Open note. The spine click uses checked on-screen coordinates to avoid the shared helper's automatic scrolling. Every placement and transport assertion remains unchanged. This changes one E2E test only.

Verification

  • Linux, Node 22.23.2, isolated Obsidian 1.14.4. Journey Transcript / Memory Palaces fixture with ten WebVTT cues at http://podnotes.test:<port>. The original flow reproduces the hidden-target timeout after its native scroll settles.
  • npm run test:e2e -- tests/e2e/journey-transcript.test.ts -t 'with the view stacked' passed 20 consecutive runs. The journey passed in both fresh-vault npm run test:e2e runs. Full run 1 had 229 passes and the unrelated settings failure below; full run 2 passed all 230 tests. It also passed on Obsidian 1.13.7. An independent runtime verifier passed the target and settings tests, 2/2.
  • npm run lint, npm run format:check, npm run typecheck, and npm run build passed. npm run test -- --run --maxWorkers=2 passed 2,757 tests plus Svelte checks. npm run test:tooling passed 35 tests. npm run docs:build built 18 pages and checked 112 legacy fragments.
  • After merging the latest master dependency and CI updates, all seven checks above passed again, and the focused journey passed on 1.14.4. No third full suite was run.
  • A product mutant using getLeaf() only for Open note failed the final placement assertion with a note in the player's own tabs. Omitting the spine click failed on the hidden button. Restoring both changes passed.

Evidence bundle, including the reproduction trace, repeated-run logs, mutation scripts, review results, and check output.

Before the spine click · After Open note

Unrelated observation from full run 1 at tests/e2e/settings-tab.test.ts:279, "blur keeps an external setting received after the focused edit was saved". The focused field was expected to retain Local/{{title}}.md, but displayed Remote/{{title}}.md. Memory was Remote/{{title}}.md and focused was true, as expected. This test passed in the independent filtered rerun and full run 2. Settings code and its test are unchanged.

Failure log · Failure screenshot. Local copies are /home/christian/.claude/orchestrate/podnotes/evidence/TEST2/settings-blur-failure-full-01.log and /home/christian/.claude/orchestrate/podnotes/evidence/TEST2/settings-blur-failure.png.

The adjacent audit found no other journey with this hidden stacked-tab pattern. Reviewing the shared helper's automatic scrolling is a larger follow-up.

Release impact

None. No product behavior, storage, settings, API, or URI changes.


Note

Low Risk
E2E test-only change with no production, API, or settings impact.

Overview
Stabilizes the stacked-transcript E2E journey by revealing the Podcast Player before Open note when Obsidian has scrolled the stacked layout to an active note and hidden the full player.

After switching focus to the stacked note, the test now waits until ui.fullPlayer is not shown, asserts the stacked-tab spine for the player is on-screen, and uses clickAt (coordinate click without the shared helper's scroll/settle behavior) to activate that spine. It imports clickAt from ./journey/input. Placement and transport assertions are unchanged; test-only, no product code.

Reviewed by Cursor Bugbot for commit a376068. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Reveal stacked player tab before opening transcript in e2e test

Updates the transcript journey test in journey-transcript.test.ts. After activating the stacked note, the test now asserts the full player is hidden, clicks the podcast player's stacked workspace-tab header, and then continues with the Open note assertions.

Macroscope summarized a376068.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying podnotes with  Cloudflare Pages  Cloudflare Pages

Latest commit: a376068
Status: ✅  Deploy successful!
Preview URL: https://635dca02.podnotes.pages.dev
Branch Preview URL: https://test-stacked-transcript-reve.podnotes.pages.dev

View logs

@chhoumann
chhoumann merged commit 5872e82 into master Oct 15, 2026
21 checks passed
@chhoumann
chhoumann deleted the test/stacked-transcript-reveal branch October 15, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E: stacked-transcript journey clicks a hidden Open note button

1 participant