Repository navigation
test(e2e): reveal the stacked player before opening a transcript - #495
Merged
Merged
Conversation
Deploying podnotes with
|
| Latest commit: |
a376068
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://635dca02.podnotes.pages.dev |
| Branch Preview URL: | https://test-stacked-transcript-reve.podnotes.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #491
The stacked-transcript journey sometimes asked for Open note after Obsidian had hidden the player. Fast isolated runs passed because the click helper's automatic scrolling interrupted Obsidian's animation and pulled the player back into view.
Wait for the player to hide, then click its visible stacked-tab spine before Open note. The spine click uses checked on-screen coordinates to avoid the shared helper's automatic scrolling. Every placement and transport assertion remains unchanged. This changes one E2E test only.
Verification
http://podnotes.test:<port>. The original flow reproduces the hidden-target timeout after its native scroll settles.npm run test:e2e -- tests/e2e/journey-transcript.test.ts -t 'with the view stacked'passed 20 consecutive runs. The journey passed in both fresh-vaultnpm run test:e2eruns. Full run 1 had 229 passes and the unrelated settings failure below; full run 2 passed all 230 tests. It also passed on Obsidian 1.13.7. An independent runtime verifier passed the target and settings tests, 2/2.npm run lint,npm run format:check,npm run typecheck, andnpm run buildpassed.npm run test -- --run --maxWorkers=2passed 2,757 tests plus Svelte checks.npm run test:toolingpassed 35 tests.npm run docs:buildbuilt 18 pages and checked 112 legacy fragments.getLeaf()only for Open note failed the final placement assertion with a note in the player's own tabs. Omitting the spine click failed on the hidden button. Restoring both changes passed.Evidence bundle, including the reproduction trace, repeated-run logs, mutation scripts, review results, and check output.
Before the spine click · After Open note
Unrelated observation from full run 1 at
tests/e2e/settings-tab.test.ts:279, "blur keeps an external setting received after the focused edit was saved". The focused field was expected to retainLocal/{{title}}.md, but displayedRemote/{{title}}.md. Memory wasRemote/{{title}}.mdandfocusedwastrue, as expected. This test passed in the independent filtered rerun and full run 2. Settings code and its test are unchanged.Failure log · Failure screenshot. Local copies are
/home/christian/.claude/orchestrate/podnotes/evidence/TEST2/settings-blur-failure-full-01.logand/home/christian/.claude/orchestrate/podnotes/evidence/TEST2/settings-blur-failure.png.The adjacent audit found no other journey with this hidden stacked-tab pattern. Reviewing the shared helper's automatic scrolling is a larger follow-up.
Release impact
None. No product behavior, storage, settings, API, or URI changes.
Note
Low Risk
E2E test-only change with no production, API, or settings impact.
Overview
Stabilizes the stacked-transcript E2E journey by revealing the Podcast Player before Open note when Obsidian has scrolled the stacked layout to an active note and hidden the full player.
After switching focus to the stacked note, the test now waits until
ui.fullPlayeris not shown, asserts the stacked-tab spine for the player is on-screen, and usesclickAt(coordinate click without the shared helper's scroll/settle behavior) to activate that spine. It importsclickAtfrom./journey/input. Placement and transport assertions are unchanged; test-only, no product code.Reviewed by Cursor Bugbot for commit a376068. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Reveal stacked player tab before opening transcript in e2e test
Updates the transcript journey test in journey-transcript.test.ts. After activating the stacked note, the test now asserts the full player is hidden, clicks the podcast player's stacked workspace-tab header, and then continues with the Open note assertions.
Macroscope summarized a376068.