Skip to content

test(e2e): reveal the stacked player before opening a transcript #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chhoumann merged 1 commit into from
Oct 15, 2026
+13 −1
Merged

test(e2e): reveal the stacked player before opening a transcript #495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion tests/e2e/journey-transcript.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
showLibrary,
showPodNotes,
} from "./journey/actions";
import { accessibleName, click, pressKey, typeInto, typeText } from "./journey/input";
import { accessibleName, click, clickAt, pressKey, typeInto, typeText } from "./journey/input";
import { PLAYER_VIEW, ui, type UiTarget } from "./journey/targets";
import { eventually, isDisabled, isShown, notices, waitUntilShown } from "./journey/wait";
import {
Expand Down Expand Up @@ -656,6 +656,18 @@ describe("transcript journeys", () => {
app.workspace.setActiveLeaf(stack.children.find((leaf) => leaf.view.file?.path === ${jsLiteral(stacked)}));
return true;
})()`);
expect(await eventually(obsidian, () => isShown(obsidian, ui.fullPlayer), false)).toBe(
false,
);
const spine = await obsidian.dev.evalJson<{ x: number; y: number; hit: boolean }>(`(() => {
const spine = document.querySelector('.workspace-tabs.mod-stacked .workspace-tab-header[data-type="${VIEW_TYPE}"]');
const rect = spine.getBoundingClientRect();
const x = rect.left + rect.width / 2;
const y = rect.top + rect.height / 2;
return { x, y, hit: spine.contains(document.elementFromPoint(x, y)) };
})()`);
expect(spine.hit, "Podcast Player's stacked-tab spine is in sight").toBe(true);
await clickAt(obsidian, spine);
await dismissNotices(obsidian);
await click(obsidian, panelButton("Open note"));
await waitForOpened(transcript);
Expand Down
Loading