fix: unify native package preparation for pip installs - #3970
Draft
TomCC7 wants to merge 1 commit into
Draft
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Follow-up to #3924 and the reported pip-install, MCAP dependency, and first-use build issues.
Problem
The Rust recorder launches from a checkout-relative directory that is absent from pip installations. The other Cachix-published native modules also carry their own checkout build paths. Core installations additionally lack MCAP support, and the recorder does not inherit a transport's custom LCM URL.
Solution
dimos native prepare <package-id>and use the same catalog in the cache publisher.dimos mem rerun. Pass the recorder's selected LCM URL and reject incompatible connections before launch.Nix remains a runtime requirement. Other native build workflows are outside this change.
How to Test
For installed-wheel recording and replay, run the included smoke script from outside the checkout using a core-only installed environment:
Passed locally on Linux:
No robot hardware validation. Local packaging used the supported Cockpit-assets opt-out; full release CI remains to run.
AI assistance
Codex (GPT-6) assisted with investigation, implementation, documentation, and validation under maintainer direction.
Checklist