Skip to content

Fix root in nix config breaking caching - #3976

Open
Dreamsorcerer wants to merge 1 commit into
mainfrom
skip-nix-root
Open

Fix root in nix config breaking caching#3976
Dreamsorcerer wants to merge 1 commit into
mainfrom
skip-nix-root

Conversation

@Dreamsorcerer

Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The native-module cache manifest now avoids treating a fileset source root as a standalone input while continuing to hash each module’s build directory. The checked mixed-root case remains covered because the module directory’s Git tree hash includes the nested input.

Confidence Score: 5/5

Safe to merge: the checked fileset-root scenario still changes the cache input when a nested real input changes.

The reported concern was exercised against both implementations. Although the changed parser omits the nested path from its intermediate collection, manifest normalization retains the enclosing module directory, whose Git tree hash covers that path.

Files Needing Attention: No files need follow-up changes.

T-Rex T-Rex Logs

What T-Rex did

  • Ran a standalone tracked-Git fixture against the parent and changed implementations to compare how path entries are collected.
  • The fixture placed a valid fileset.toSource root and a separate root = ./real-input in the same flake.
  • The changed parser omitted module/real-input from its intermediate collection, while the manifest retained module as the path entry and its Git tree hash covers changes below module/real-input.
  • The parent implementation retained module as the effective manifest path entry.
  • Hash-path validation shows the changed code omits the real-input token while the parent includes it, so the effective hash input remains module and final manifest path entries are ['module'] for both revisions.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "Fix root in nix config breaking caching" | Re-trigger Greptile

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3976      +/-   ##
==========================================
- Coverage   77.91%   77.91%   -0.01%     
==========================================
  Files        1398     1398              
  Lines      132268   132274       +6     
  Branches    11487    11489       +2     
==========================================
- Hits       103061   103058       -3     
- Misses      25943    25950       +7     
- Partials     3264     3266       +2     
Components Coverage Δ
Tests 94.72% <100.00%> (-0.02%) ⬇️
Flag Coverage Δ
OS-ubuntu-24.04-arm 74.25% <100.00%> (-0.01%) ⬇️
OS-ubuntu-latest 74.75% <100.00%> (-0.01%) ⬇️
Py-3.10 74.75% <100.00%> (-0.01%) ⬇️
Py-3.11 74.75% <100.00%> (-0.01%) ⬇️
Py-3.12 74.75% <100.00%> (+<0.01%) ⬆️
Py-3.13 74.75% <100.00%> (-0.01%) ⬇️
Py-3.14 74.75% <100.00%> (-0.01%) ⬇️
Py-3.14t 74.75% <100.00%> (+<0.01%) ⬆️
SelfHosted-Large 30.71% <14.28%> (-0.01%) ⬇️
SelfHosted-Linux 35.77% <14.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dimos/core/test_build_native_modules.py 90.41% <100.00%> (+0.35%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant