fix(memory): store depth images losslessly instead of as JPEG - #4021
Draft
jeff-hykin wants to merge 1 commit into
Draft
fix(memory): store depth images losslessly instead of as JPEG#4021jeff-hykin wants to merge 1 commit into
jeff-hykin wants to merge 1 commit into
Conversation
codec_for() picks a codec from the payload type alone, and Image covers both colour and depth, so every depth frame was routed to JpegCodec. Float32 depth raised out of turbojpeg, making a depth stream unrecordable, and uint16 depth silently went through the /256 rescale in to_rgb() and came back as wrong metres.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4021 +/- ##
=======================================
Coverage 78.08% 78.09%
=======================================
Files 1416 1416
Lines 133556 133569 +13
Branches 11578 11579 +1
=======================================
+ Hits 104291 104314 +23
+ Misses 25978 25968 -10
Partials 3287 3287
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depth frames were being routed to the JPEG codec because
codec_for()dispatches on payload type alone andImagecovers both colour and depth. Float32 depth crashed out of turbojpeg so it could not be recorded at all, and uint16 depth silently came back as wrong metres.