ci: skip the self-hosted macOS tests in the merge queue - #4036
Closed
mustafab0 wants to merge 2 commits into
Closed
Conversation
One macOS runner serves the whole org, so a merge_group entry queues behind every other consumer of it. Waiting long enough gets the leg cancelled, and cancelled is neither success nor skipped, so alls-green fails ci-complete and the queue ejects the PR. It requeues and does it again: 9 of the last 50 merge-queue ci runs were cancelled, across three authors. continue-on-error covers a macOS failure, which is why the red X on a PR does not block anything. It does nothing for a cancellation. self-hosted-tests is a matrix job and job-level `if` cannot read matrix, so the include list moves into compute-ros-pin, which already computes the container digest the Linux leg needs. On merge_group it emits Linux only. Every pull request still runs both legs, so nothing stops being tested before merge.
mustafab0
requested review from
Dreamsorcerer,
leshy,
paul-nechifor and
spomichter
as code owners
September 10, 2026 01:19
Contributor
|
mustafab0
force-pushed
the
mb/ci-skip-macos-in-merge-queue
branch
from
September 10, 2026 01:28
c20b0df to
079959a
Compare
❌ 7 Tests Failed:
View the full list of 7 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One macOS runner serves the whole org, so a
merge_groupentry queues behind every other consumer of it.Solution is to not run the macOS test in merge queue