Skip to content

fix_7_mac_tests: 2 fix - 5 skip - #4050

Open
bogwi wants to merge 1 commit into
mainfrom
danvi/chores/fix_7_mac_tests
Open

fix_7_mac_tests: 2 fix - 5 skip#4050
bogwi wants to merge 1 commit into
mainfrom
danvi/chores/fix_7_mac_tests

Conversation

@bogwi

@bogwi bogwi commented Sep 10, 2026

Copy link
Copy Markdown
Member

Fix 7 failing tests on mac.

2 - real fix, they should now pass on macOS

The 5 nix ones: not fixable as tests, they are skipped

@TomCC7 TomCC7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manipulation changes lgtm

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

Safe to merge; no behavior that would block merging was found.

What we checked:

  • The reviewer compared the base revision with the proposed changes for the macOS self-hosted test matrix, the Rust recorder prerequisite handling, and the CAN-bus test seams. T-Rex
  • They confirmed the proposed configuration enables the macOS matrix leg with the expected labels, and both adapter fixtures use _make_can_bus instead of patching SocketCanBus. T-Rex
  • They executed the Rust recorder fixture in a non-Nix environment and observed it reported skipped: nix builds the recorder binary before attempting any build. T-Rex
  • They attempted a full self-hosted collection but could not complete because pyaudio==0.2.14 requires the missing /usr/include/portaudio.h header. T-Rex
  • After the changes, the HEAD assertions pass and the executed fixture reports skipped, while the dynamic blocker remains due to the missing portaudio.h header affecting uv run environment creation. T-Rex

Summary

  • No actionable issues found. The macOS self-hosted test leg is enabled with its intended runner labels, Rust recorder tests skip cleanly when Nix is unavailable, and hardware adapter tests use the adapter-level CAN-bus construction seam.
  • T-Rex validation blocked

  • Full self-hosted test collection could not run because building pyaudio==0.2.14 requires the missing /usr/include/portaudio.h header. The focused no-Nix recorder-fixture behavior and the changed CI/test configuration were exercised successfully.

Reviews (1) · Last reviewed commit: "fix_7_mac_tests: 2 fix, 5 skip"

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #4050      +/-   ##
==========================================
- Coverage   78.14%   78.14%   -0.01%     
==========================================
  Files        1429     1429              
  Lines      134926   134929       +3     
  Branches    11706    11707       +1     
==========================================
  Hits       105439   105439              
- Misses      26159    26167       +8     
+ Partials     3328     3323       -5     
Components Coverage Δ
Tests 94.72% <100.00%> (+<0.01%) ⬆️
Flag Coverage Δ
OS-ubuntu-24.04-arm 74.45% <40.00%> (+<0.01%) ⬆️
OS-ubuntu-latest 75.02% <40.00%> (-0.01%) ⬇️
Py-3.10 75.02% <40.00%> (-0.01%) ⬇️
Py-3.11 75.01% <40.00%> (-0.01%) ⬇️
Py-3.12 75.02% <40.00%> (-0.01%) ⬇️
Py-3.13 75.02% <40.00%> (+<0.01%) ⬆️
Py-3.14 75.02% <40.00%> (+<0.01%) ⬆️
Py-3.14t 75.02% <40.00%> (-0.01%) ⬇️
SelfHosted-Large 30.77% <20.00%> (-0.01%) ⬇️
SelfHosted-Linux 35.58% <60.00%> (-0.01%) ⬇️
SelfHosted-macOS 34.64% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...imos/experimental/memory/test_rust_recorder_e2e.py 91.74% <100.00%> (+0.12%) ⬆️
...are/whole_body/dual_openyam_damiao/test_adapter.py 100.00% <100.00%> (ø)
...hardware/whole_body/openarm_damiao/test_adapter.py 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Sep 10, 2026
@bogwi
bogwi enabled auto-merge September 10, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants