realsense: tell the linker where nix actually put librealsense2 - #4054
Merged
Merged
Conversation
nixpkgs' realsense2.pc names lib/x86_64-linux-gnu but the .so is in lib/. build.rs already walked up to the real directory for the rpath; now it emits it as a link-search path too, so `-lrealsense2` resolves and the native module builds from a fresh nix store. Cargo.lock refreshed against the dimos-module crate it points at.
leshy
requested review from
Dreamsorcerer,
aclauer,
mustafab0,
paul-nechifor and
spomichter
as code owners
September 10, 2026 08:52
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4054 +/- ##
==========================================
- Coverage 78.22% 78.20% -0.02%
==========================================
Files 1431 1428 -3
Lines 135204 135077 -127
Branches 11711 11708 -3
==========================================
- Hits 105762 105643 -119
+ Misses 26167 26112 -55
- Partials 3275 3322 +47
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
spomichter
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dimos runof anything with aRealSenseCamerafails its native build with