Repository navigation
misaki-g2p/parakeet: fix GCC and Windows CI build breaks - #74
Conversation
- tagger.cpp used std::all_of without <algorithm>; GCC and the Windows clang toolchains reject it. Include <algorithm> in every misaki-g2p and parakeet source that uses std::min/std::max/std::all_of. - GCC ignores [[maybe_unused]] on a non-static data member and -Werror=attributes turned that into an error in misaki-internal.h. Drop the attribute and reference data_dir_ in the no-espeak path so clang's -Wunused-private-field stays quiet. - lexicon.cpp munmap cast dropped const via a C cast (-Wcast-qual). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
test-kokoro-layer-options compared the fast and libm Snake paths with a fixed 1e-6 bound on |diff| * |a|. Both paths round x + sin^2(a x) / a to float, so for |x| near 8-16 the output ulp alone (~9.5e-7) times |a| exceeds that bound. Every Linux, Windows and macOS-x64 job now reaches this test (misaki-g2p no longer stops the build first), and all of them failed it with 1.06e-06. Subtract one output ulp before scaling, so the check still bounds the fast_sin2 error (observed 2.4-2.8e-07) and no longer counts float rounding of the sum. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
With the misaki-g2p break fixed, every CPU job now builds and reaches ctest. That exposed one test that was already failing: 🤖 Generated with Claude Code |
|
Merging. 31 checks pass. The only failure is macOS-latest-arm64 🤖 Generated with Claude Code |
Fixes the build breaks that stop the GCC and Windows CI jobs in
tools/misaki-g2pbefore parakeet compiles (seen on #73):tagger.cpp:266:std::all_ofused without<algorithm>(ubuntu-24-webgpu,build-cmake-pkg, Windows clang jobs).<algorithm>is now included in every misaki-g2p and parakeet source that usesstd::min,std::maxorstd::all_of.misaki-internal.h:159: GCC ignores[[maybe_unused]]on a non-static data member, which-Werror=attributesturns into an error (ubuntu-cpu,ggml-ci-*). The attribute is gone.data_dir_is now referenced in the no-espeak path so clang's-Wunused-private-fieldstays quiet.lexicon.cpp: the C-style cast inmunmapdropped const (-Wcast-qual). It's now aconst_cast.Local check: GCC 15 with
-DLLAMA_FATAL_WARNINGS=ONcompiles every misaki-g2p, parakeet, omnivoice/elizainference and voice test translation unit with no warnings intools/.paradee.cppand ggml-cpu can't be built with GCC on macOS because Apple's Accelerate SDK headers don't compile under GCC, and that isn't related to this change. Apple clang builds and host tests run in the follow-up pin-to-main merge.AI assistance disclosure: an AI coding assistant (Claude Code) wrote this change. A maintainer-authorised agent reviewed it.
🤖 Generated with Claude Code