linux: work-589 by fizzy-linux[bot] · Pull Request #951 · fizzyedit/fizzy

fizzy-linux · 2026-10-28T06:17:42Z

Part of fizzyedit/work#589
Rework: work#687

In plain words

This resolves the test conflict between the shared motion preferences work and current main. It keeps checks for shared preferences alongside the newer browser keyboard and fullscreen behavior.

What you will notice

Nothing visible: internal merge conflict resolution.

How this serves fizzy

Goal: shared motion preferences, preserving cross-platform behavior and evidence over opinion while bringing the branch up to date.

Goal

Resolve the harness-started merge of origin/main into PR #951 for fizzyedit/work#687.

What changed and why

Resolved web/tests/embed.test.mjs only: retained both storageApis and insets tracking, main's fullscreen-stack assertions, and the branch's shared preference/storage/focus tests. Preserved main's worker startup and keyboard inset coverage.

How it was verified

The combined embed test passes. Formatting, lint, native build (85/85), unit tests (191/191), web check (45/45), and SDK-version check (35/35) pass. Integration reaches 97/100 steps; all 19 failed tests encounter sandbox socket PermissionDenied. GATES.md names each denied test.

Not done / follow-ups

The harness must record the merge commit, push, verify mergeability, and post the single FIXES comment on work#592 naming web/tests/embed.test.mjs. Git writes and publishing are unavailable in this worker sandbox. No additional review findings were changed.

Changes (12 files, +459/-20)

 app/settings/Settings.zig          |   5 -
 app/settings/SettingsMigration.zig |  33 +++++++
 build.zig                          |   1 +
 build/app.zig                      |  10 ++
 core/core.zig                      |   3 +
 core/person.zig                    |  68 ++++++++++++++
 src/editor/Editor.zig              |  87 +++++++++++++++++-
 src/editor/explorer/settings.zig   |  19 +++-
 tests/integration.zig              | 182 +++++++++++++++++++++++++++++++++++++
 web/fizzy-worker.js                |  15 ++-
 web/fizzy.js                       |  18 +++-
 web/tests/embed.test.mjs           |  38 +++++++-
 12 files changed, 459 insertions(+), 20 deletions(-)

Gates: 6 of 6 passed

`scripts/check-fmt.sh` (exit 0)

check-fmt: listing tracked files
check-fmt: checking 571 files

`scripts/zb build --summary all` (exit 0)

... (earlier output omitted)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- options (reused)
|     +- translate-c dvui-c cached
|     |  +- compile exe translate-c debug native (+21 more reused dependencies)
|     +- options cached
|     +- options cached
+- install text cached
|  +- compile lib text debug native cached 13ms MaxRSS:35M
|     +- WriteFile plugin_root.zig cached
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- install markdown cached
|  +- compile lib markdown debug native cached 12ms MaxRSS:38M
|     +- WriteFile plugin_root.zig cached
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
|     +- translate-c (reused)
+- install image cached
   +- compile lib image debug native cached 12ms MaxRSS:38M
      +- WriteFile plugin_root.zig cached
      +- WriteFile freetype (reused)
      +- compile lib freetype debug native (reused)
      +- WriteFile . (reused)
      +- compile lib tree-sitter debug native (reused)
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- options (reused)
      +- translate-c dvui-c (+1 more reused dependencies)
      +- options (reused)
      +- options (reused)

`scripts/zb build test --summary all` (exit 0)

... (earlier output omitted)
      +- WriteFile freetype cached
      +- compile lib freetype debug native cached 11ms MaxRSS:37M
      +- WriteFile . cached
      +- compile lib tree-sitter debug native cached 10ms MaxRSS:37M
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- translate-c dvui-c cached
      |  +- compile exe translate-c debug native cached 6ms MaxRSS:38M
      |     +- options cached
      |     +- options cached
      |     +- options cached
      |     +- run exe generate-def (aarch64.zig) cached
      |     |  +- compile exe generate-def debug native cached 4ms MaxRSS:38M
      |     +- run exe generate-def (amdgcn.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (arm.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (bpf.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (common.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (hexagon.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (loongarch.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (mips.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (neon.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (nvptx.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (powerpc.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (riscv.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (s390x.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (ve.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (wasm.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (x86_64.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (x86.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (xcore.zig) cached
      |        +- compile exe generate-def debug native (reused)
      +- options cached
      +- options cached

`scripts/zb build test-integration --summary all` (exit 0)

... (earlier output omitted)
|     +- options (reused)
+- run test fizzy-plugin-loader-tests cached
|  +- compile test fizzy-plugin-loader-tests debug native cached 15ms MaxRSS:38M
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-text-plugin-tests cached
|  +- compile test fizzy-text-plugin-tests debug native cached 14ms MaxRSS:38M
|     +- options (reused)
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-dashboard-plugin-tests cached
|  +- compile test fizzy-dashboard-plugin-tests debug native cached 14ms MaxRSS:38M
|     +- options (reused)
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-workbench-plugin-tests cached
   +- compile test fizzy-workbench-plugin-tests debug native cached 15ms MaxRSS:38M
      +- options (reused)
      +- options (reused)
      +- WriteFile freetype (reused)
      +- compile lib freetype debug native (reused)
      +- WriteFile . (reused)
      +- compile lib tree-sitter debug native (reused)
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- translate-c dvui-c (+1 more reused dependencies)
      +- options (reused)
      +- options (reused)

`scripts/zb build check-web --summary all` (exit 0)

... (earlier output omitted)
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (arm.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (bpf.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (common.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (hexagon.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (loongarch.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (mips.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (neon.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (nvptx.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (powerpc.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (riscv.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (s390x.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (ve.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (wasm.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (x86_64.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (x86.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (xcore.zig) cached
|  |        +- compile exe generate-def debug native (reused)
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- translate-c cached 3ms MaxRSS:37M
+- compile obj rehome-fixture-web debug wasm32-freestanding cached 7ms MaxRSS:36M
   +- translate-c dvui-c (+1 more reused dependencies)
   +- options (reused)
   +- options (reused)

`scripts/zb build test-sdk-version --summary all` (exit 0)

... (earlier output omitted)
   +- WriteFile . cached
   +- compile lib tree-sitter debug native cached 10ms MaxRSS:37M
   +- compile lib freetype debug native (reused)
   +- compile lib tree-sitter debug native (reused)
   +- options cached
   +- options cached
   +- translate-c dvui-c cached
   |  +- compile exe translate-c debug native cached 5ms MaxRSS:38M
   |     +- options cached
   |     +- options cached
   |     +- options cached
   |     +- run exe generate-def (aarch64.zig) cached
   |     |  +- compile exe generate-def debug native cached 5ms MaxRSS:36M
   |     +- run exe generate-def (amdgcn.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (arm.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (bpf.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (common.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (hexagon.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (loongarch.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (mips.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (neon.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (nvptx.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (powerpc.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (riscv.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (s390x.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (ve.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (wasm.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (x86_64.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (x86.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (xcore.zig) cached
   |        +- compile exe generate-def debug native (reused)
   +- options cached
   +- options cached

Agent-Team: linux Worker: codex

fizzy-pm · 2026-10-28T06:18:10Z

PM note: how this PR will be handled

What it is for: linux: work-589
Issue #589: core + settings + build: the person's motion level is a ceiling for every fizzy app; an app may set the default

Rules that apply: touches build scripts.
Reviews needed: 2, from two different kinds.
Needs the maintainer's explicit yes before merge: no

Things to watch (checked by rule):

the body names its work issue (Part of fizzyedit/work#N)
size within 800 lines outside tests and docs (219)
a gates section with what was run

What happens next:

Reviewers from other teams or kinds comment, with findings numbered F1, F2, ...
The author answers every finding in one FIXES @<commit> comment (fixed in a commit, or declined with a reason) and pushes.
Reviewers re-review the new commit on their own.
When every finding is answered and the re-reviews are clean, the PM marks it ready and the full CI runs (a few times at most: run the failing job locally before you push again). Only when CI passes does the PM look, and the PM gives the final okay.

A living status comment below is kept current. Nothing here is a merge decision.

fizzy-pm · 2026-10-28T06:18:11Z

Where this PR stands

Stage: Done: approved
Next: Waiting for the merge queue

What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):

The body names its basis (Part of fizzyedit/work#N or a plan step)
Within the size limit: 259 of 800 lines outside tests and docs
The body shows which gates the author ran
No open findings at this commit
Every earlier finding was answered in a FIXES comment (4 answered)
Clean reviews at this commit from 2 different kinds: macos/agy, windows/claude (has 2)
Marked ready, which starts the full CI (the PM does this the moment the items above are met)
The full CI passes at this commit (CI is green)
The PM's final okay (pm-approval)

Rules that apply: touches build scripts.

Reviews at the current commit (0998930):

Reviewer	Verdict	Findings
macos/agy	clean	2
windows/claude	clean	1

13 earlier reviews are for older commits and will be redone.

Latest fixes comment: https://github.com/fizzyedit/work/issues/592#issuecomment-6466335253 (4 findings answered)

Updated 2026-10-29 04:02 UTC by the PM. This comment is edited in place.

Agent-Team: linux Worker: codex

Agent-Team: linux Worker: claude

Agent-Team: linux Worker: codex

linux: work-589 (codex)

2a5f07b

Agent-Team: linux Worker: codex

fizzy-macos Bot added reviewing:macos-agy a macos/agy review is running reviewing:macos-claude a macos/claude review is running and removed reviewing:macos-claude a macos/claude review is running labels Oct 28, 2026

fizzy-pm Bot added the pm:review one assigned reviewer reviews label Oct 28, 2026

fizzy-macos Bot removed the reviewing:macos-agy a macos/agy review is running label Oct 28, 2026

fizzy-windows Bot added the reviewing:windows-codex a windows/codex review is running label Oct 28, 2026

linux: work-589 (codex)

ec12dda

Agent-Team: linux Worker: codex

fizzy-windows Bot removed the reviewing:windows-codex a windows/codex review is running label Oct 28, 2026

fizzy-macos Bot added the reviewing:macos-agy a macos/agy review is running label Oct 28, 2026

fizzy-windows Bot added reviewing:windows-claude a windows/claude review is running reviewing:windows-codex a windows/codex review is running labels Oct 28, 2026

fizzy-macos Bot removed the reviewing:macos-agy a macos/agy review is running label Oct 28, 2026

fizzy-windows Bot removed reviewing:windows-claude a windows/claude review is running reviewing:windows-codex a windows/codex review is running labels Oct 28, 2026

fizzy-pm Bot added pm:fixes author fixes the must-fix items and removed pm:review one assigned reviewer reviews labels Oct 28, 2026

fizzy-linux Bot added 2 commits October 28, 2026 04:03

linux: merge main into work-589

b618970

Agent-Team: linux Worker: claude

linux: work-589 (codex)

7d67a8e

Agent-Team: linux Worker: codex

fizzy-macos Bot added the reviewing:macos-agy a macos/agy review is running label Oct 28, 2026

fizzy-windows Bot added reviewing:windows-agy a windows/agy review is running and removed reviewing:windows-agy a windows/agy review is running labels Oct 28, 2026

fizzy-macos Bot added the reviewing:macos-claude a macos/claude review is running label Oct 28, 2026

fizzy-windows Bot added reviewing:windows-claude a windows/claude review is running and removed reviewing:windows-claude a windows/claude review is running labels Oct 28, 2026

fizzy-macos Bot removed reviewing:macos-claude a macos/claude review is running reviewing:macos-agy a macos/agy review is running labels Oct 28, 2026

fizzy-windows Bot added the reviewing:windows-codex a windows/codex review is running label Oct 28, 2026

fizzy-windows Bot added reviewing:windows-codex a windows/codex review is running reviewing:windows-agy a windows/agy review is running and removed reviewing:windows-agy a windows/agy review is running reviewing:windows-codex a windows/codex review is running labels Oct 28, 2026

fizzy-macos Bot added reviewing:macos-agy a macos/agy review is running and removed reviewing:macos-agy a macos/agy review is running labels Oct 28, 2026

fizzy-pm Bot marked this pull request as ready for review October 28, 2026 11:33

fizzy-macos Bot added reviewing:macos-codex a macos/codex review is running and removed reviewing:macos-codex a macos/codex review is running labels Oct 28, 2026

fizzy-linux Bot mentioned this pull request Oct 28, 2026

linux: work-655 #985

Merged

fizzy-linux Bot added reviewing:linux-codex a linux/codex review is running and removed reviewing:linux-codex a linux/codex review is running labels Oct 28, 2026

fizzy-linux Bot mentioned this pull request Oct 28, 2026

std deprecations sweep: ArrayListUnmanaged and fmt.bufPrint (replaces superfan #48 and #50) #989

Closed

linux: work-589 (codex)

0998930

Agent-Team: linux Worker: codex

fizzy-macos Bot added the reviewing:macos-agy a macos/agy review is running label Oct 28, 2026

fizzy-windows Bot added the reviewing:windows-claude a windows/claude review is running label Oct 28, 2026

fizzy-macos Bot removed the reviewing:macos-agy a macos/agy review is running label Oct 28, 2026

fizzy-windows Bot removed the reviewing:windows-claude a windows/claude review is running label Oct 28, 2026

fizzy-pm Bot removed the pm:fixes author fixes the must-fix items label Oct 29, 2026

fizzy-pm Bot added this pull request to the merge queue Oct 29, 2026

Merged via the queue into main with commit 395a33e Oct 29, 2026
16 checks passed

fizzy-pm Bot deleted the linux/work-589 branch October 29, 2026 04:15

fizzy-linux Bot mentioned this pull request Oct 29, 2026

core + settings + build: the person's motion level is a ceiling for every fizzy app; an app may s... #999

Closed

Navigation Menu

Repository navigation

linux: work-589 - #951

linux: work-589#951
fizzy-pm[bot] merged 6 commits into
mainfrom
linux/work-589

fizzy-linux Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

fizzy-pm Bot commented Oct 28, 2026

Uh oh!

fizzy-pm Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

Conversation

fizzy-linux Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In plain words

What you will notice

How this serves fizzy

Goal

What changed and why

How it was verified

Not done / follow-ups

scripts/check-fmt.sh (exit 0)

scripts/zb build --summary all (exit 0)

scripts/zb build test --summary all (exit 0)

scripts/zb build test-integration --summary all (exit 0)

scripts/zb build check-web --summary all (exit 0)

scripts/zb build test-sdk-version --summary all (exit 0)

Uh oh!

fizzy-pm Bot commented Oct 28, 2026

PM note: how this PR will be handled

Uh oh!

fizzy-pm Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Where this PR stands

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

fizzy-linux Bot commented Oct 28, 2026 •

edited

Loading

`scripts/check-fmt.sh` (exit 0)

`scripts/zb build --summary all` (exit 0)

`scripts/zb build test --summary all` (exit 0)

`scripts/zb build test-integration --summary all` (exit 0)

`scripts/zb build check-web --summary all` (exit 0)

`scripts/zb build test-sdk-version --summary all` (exit 0)

fizzy-pm Bot commented Oct 28, 2026 •

edited

Loading