add basic repl support by milomg · Pull Request #173 · kobaltedev/solidbase

milomg · 2026-10-03T04:56:19Z

No description provided.

netlify · 2026-10-03T04:56:25Z

❌ Deploy Preview for solidbase failed.

Name	Link
🔨 Latest commit	`bb14a31`
🔍 Latest deploy log	https://app.netlify.com/projects/solidbase/deploys/6ae156efd5d4172172d6fa09

devagrawal09

Nice work overall: the remark plugin is clean with good author-facing errors, and SSR/worker cleanup are handled well. I got it running locally by linking packages/solid-repl from the playground, and all four examples on /repl work.

Blocking:

solid-repl isn't declared anywhere, and the rewritten package isn't published yet (npm still has the old 0.26.0), so CI can't build it.
pnpm-lock.yaml isn't updated for the new dev/ deps, so frozen installs fail.
The plugin is registered unconditionally (inline comment).

Also: no tests for the remark plugin or the CSS rewrite, which solidbase has for its other remark plugins.

devagrawal09 · 2026-10-04T19:22:05Z

 		}

 		return [
+			solidReplVitePlugin(),


This runs for every site using the default theme, and the plugin calls require.resolve("solid-repl/package.json") at config load, so any site without solid-repl installed fails to start. It also applies the define/dedupe settings site-wide. Could this be opt-in (config flag, or only when solid-repl resolves), with solid-repl as an optional peer dep?

devagrawal09 · 2026-10-04T19:22:05Z

+			return {
+				// solid-repl's workers bundle Babel, which reads `process.env` at load time.
+				// Defining one key makes Vite create a `process` global inside workers.
+				define: {


These defines apply to the whole app, not just the workers. Worth scoping if possible, or at least gating with the opt-in above.

devagrawal09 · 2026-10-04T19:22:05Z

+// dockview theming keyed on `#app` and dark mode keyed on a `.dark` ancestor.
+// Drop the reset (Repl.module.css re-applies it scoped to the REPL) and rewrite
+// the selectors so the rest only affects the embedded REPL.
+export function scopeSolidReplCss(code: string) {


Checked this against the current solid-repl bundle and it works (reset removed, #app fully rewritten, nothing global leaks). Since it pattern-matches another package's output, a unit test with a fixture would catch it silently breaking when solid-repl changes.

devagrawal09 · 2026-10-04T19:22:05Z

+	const text = useThemeText();
+
+	// The worker protocol is not multiplexed, so each playground gets its own workers.
+	const compiler = new CompilerWorker();


Each REPL starts 4 workers on load (incl. TS); a page with 4 REPLs started 16, with four copies of the ~9.6 MB linter. Starting them when the REPL scrolls into view or gets focus would help a lot.

devagrawal09

A few more from a second pass, all reproduced locally. One correction to my earlier scopeSolidReplCss comment: no global selectors (html/:root/*) with real styles leak, but Panda's utility classes (.d_flex etc.) stay global, which only matters for host sites that also use Panda.

devagrawal09 · 2026-10-04T19:45:00Z

+
+function getTabName(code: Code, index: number, file?: VFile) {
+	const title = new MetaOptions(code.meta ?? "").getString("title");
+	if (title) return title;


If the first block has a title (e.g. title="App.tsx"), no main.tsx is produced, and the preview only updates when ./main exists (solid-repl/src/components/preview.tsx:278), so it stays blank with no error. Either always name the first block main.tsx or fail when no tab is main.tsx.

devagrawal09 · 2026-10-04T19:45:01Z

 import { usePreferredLanguage } from "../client/preferred-language.js";
 import CopyPageLink from "../default-theme/components/CopyPageLink.jsx";
 import { Preview, PreviewPanel, PreviewStage } from "./components/Preview.jsx";
+import { Repl } from "./components/Repl.jsx";


Because Repl is always registered, every site build emits the worker bundles even with no REPL on any page: removing repl.mdx from dev/ still produced ~19.5 MB of workers (linter 9.2 MB, tsWorker 7.0 MB, compiler 2.7 MB, formatter 0.6 MB). Same fix as the opt-in comment on index.ts.

devagrawal09 · 2026-10-04T19:45:01Z

+		(typeof props.devtools === "string" && props.devtools !== "false");
+
+	return (
+		<ErrorBoundary


The workers are constructed in the component body above, so a constructor failure (or the failed dynamic import in Repl.tsx) isn't caught by this boundary and the replError fallback never shows. Wrapping <ReplClient> in the boundary from Repl.tsx would cover both.

devagrawal09 · 2026-10-04T19:45:01Z

+					// solid-repl's compiled output imports panda's generated runtime,
+					// which the package ships in dist/styled-system.
+					alias: {
+						"styled-system": join(solidReplRoot, "dist/styled-system"),


This alias is global, so a host site that uses Panda's own styled-system would get the REPL's copy instead. Only matters for Panda-based sites, but worth scoping to imports from solid-repl.

jer3m01 · 2026-10-06T09:50:37Z

Thanks for the PR!

Think we should get the Solid 2 PR merged first, I don't plan on adding features to v1 (only maintainance).

jer3m01 · 2026-10-27T19:55:25Z

PR migrating to Solid 2 merged and released.
@milomg @devagrawal09 able to solve conflicts & fixes for 2.0?

socket-security · 2026-10-28T01:59:51Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	solid-repl@0.26.0

View full report

socket-security · 2026-10-28T01:59:53Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Priority	Alert (click "▶" to expand/collapse)	Action
	Critical CVE: DOMPurify SAFE_FOR_TEMPLATES bypass: split template expressions survive in attached shadow root content on DOM output modes CVE: GHSA-cg2g-xh64-v4q7 DOMPurify SAFE_FOR_TEMPLATES bypass: split template expressions survive in attached shadow root content on DOM output modes (CRITICAL) Affected versions: >= 3.4.4 < 3.4.17 Patched version: 3.4.17 From: package.json → `npm/solid-repl@0.26.0` → `npm/dompurify@3.4.15` ℹ Read more on: This package \| This alert \| What is a critical CVE? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/dompurify@3.4.15`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.	Warn

View full report

devagrawal09 · 2026-10-29T04:05:26Z

@milomg I opened #177 with your commit plus fixes for SolidBase 2.0 and the published solid-repl@1.0.1: rc.19, the lockfile that broke this preview, and the missing-package fallback. I couldn't push to your branch, and this lets the preview and review start as @jer3m01 asked. Are you OK closing this in favour of #177? If you'd rather keep this one, merging milomg#1 into your branch gives the same result. I've closed that one so there's a single place to review.

— Claude (Opus 5.5), posting on behalf of @devagrawal09

devagrawal09 mentioned this pull request Oct 3, 2026

Solid 2: port to solid-js 2 + @solidjs/vite-plugin start mode (SSG, router 2, meta 1.0) #174

Merged

13 tasks

devagrawal09 reviewed Oct 4, 2026

View reviewed changes

milomg force-pushed the main branch from 130cd07 to 289a98e Compare October 4, 2026 23:33

add basic repl support

bb14a31

milomg force-pushed the main branch from 289a98e to bb14a31 Compare October 28, 2026 01:59

This was referenced Oct 29, 2026

SolidBase 2 REPL support milomg/solidbase#1

Closed

feat: REPL support for Solid 2 (builds on #173) #177

Open

milomg closed this Oct 29, 2026

Conversation

milomg commented Oct 3, 2026

Uh oh!

netlify Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for solidbase failed.

Uh oh!

devagrawal09 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devagrawal09 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jer3m01 commented Oct 6, 2026

Uh oh!

jer3m01 commented Oct 27, 2026

Uh oh!

socket-security Bot commented Oct 28, 2026

Uh oh!

socket-security Bot commented Oct 28, 2026

Uh oh!

devagrawal09 commented Oct 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented Oct 3, 2026 •

edited

Loading