Repository navigation
feat: REPL support for Solid 2 (builds on #173) - #177
devagrawal09 wants to merge 9 commits into
Conversation
✅ Deploy Preview for solidbase ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Fixes the formatter error and the unused onCleanup import from the previous pace commit; no behaviour change.
|
Added a full screen mode. Each REPL now has a Full screen button above it. Why the output was hard to use: inline, the preview is about 826×143px on desktop (under a third of the 32rem box) and sits behind a tab on mobile. Full screen makes it 545×819px at 1440×900, beside the editor, and 390×762px on a 390×844 phone. The new button row takes about 13px from the inline preview. How it behaves
Why not the native Fullscreen API: solid-repl portals its menus to Trade-offs
To try it: open Tested in Chromium at desktop, emulated mobile and tablet sizes, in light and dark, and under I also pushed — Claude (Opus 5.5), posting on behalf of @devagrawal09 |

REPL support for SolidBase 2, building on @milomg's #173. It contains his commit (
bb14a31, rebased onto Solid 2) unchanged, plus three fixes from milomg#1. I can't push to his branch, so this PR gets a preview and review going now, as @jer3m01 asked on #173. Happy to close it if milomg prefers to land #173 himself.Feature (from #173)
solid-replplayground.Repl/ReplClientload client-only throughclientOnly, with anErroredfallback. Compiler and formatter workers are shared between REPLs on a page.solid-replis an optional peer dependency. Without it, a stand-in component renders.dev/src/routes/repl.mdx.Fixes on top
solid-repl@^1.0.1for library development and the dev app; constrain its optional peer to^1.0.0.Commits:
ae6273adependencies;5bef30efallback;ad6d032existing-suite tests.Verification
/and/docs/: edit/compile, counter clicks, formatting, themes and worker cleanup/recreation passed. Four REPLs share compiler/formatter workers; total workers go 6 → 0 → 6 on navigation. No hydration errors or diagnostics traced to SolidBase.Known upstream issues
solid-repl@1.0.1has intermittent language-workerTypeError: n is not a functionand embedded chii devtools errors. No vendor patches included.Notes
pnpm devindev/).Supersedes #173.
— Claude (Opus 5.5), posting on behalf of @devagrawal09