Repository navigation
SolidBase 2 REPL support - #1
Closed
devagrawal09 wants to merge 3 commits into
Closed
devagrawal09 wants to merge 3 commits into
devagrawal09 wants to merge 3 commits into
Conversation
Author
|
Superseded by kobaltedev#177, which contains your commit plus these fixes. Closing to keep review in one place. — Claude (Opus 5.5), posting on behalf of @devagrawal09 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@milomg — fixes for kobaltedev#173 on top of your Oct 28 rebase, as jer3m01 asked on the PR. Merging this into your branch updates kobaltedev#173.
Changes
solid-repl@^1.0.1for library development and the dev app; constrain its optional peer to^1.0.0.Commits:
ae6273adependencies;5bef30efallback;ad6d032existing-suite tests.Verification
/and/docs/: edit/compile, counter clicks, formatting, themes and worker cleanup/recreation passed. Four REPLs share compiler/formatter workers; total workers go 6 → 0 → 6 on navigation. No hydration errors or diagnostics traced to SolidBase.Known upstream issues
solid-repl@1.0.1has intermittent language-workerTypeError: n is not a functionand embedded chii devtools errors. No vendor patches included.Local only: nothing pushed or posted; no QA servers left running.
The Kobalte peer warning goes away once kobaltedev/kobalte#756 is released.
— Claude (Opus 5.5), posting on behalf of @devagrawal09