Skip to content

SolidBase 2 REPL support - #1

Closed
devagrawal09 wants to merge 3 commits into
milomg:mainfrom
devagrawal09:repl-solid2
Closed

devagrawal09 wants to merge 3 commits into
milomg:mainfrom
devagrawal09:repl-solid2

Conversation

@devagrawal09

Copy link
Copy Markdown

@milomg — fixes for kobaltedev#173 on top of your Oct 28 rebase, as jer3m01 asked on the PR. Merging this into your branch updates kobaltedev#173.

Changes

  • Align root, dev and docs with Solid/Web rc.19 and update the pnpm 11.20.0 lockfile. Keep library Solid peer ranges and the Vite plugin unchanged.
  • Install published solid-repl@^1.0.1 for library development and the dev app; constrain its optional peer to ^1.0.0.
  • Use a file-backed missing-package fallback so prerender can find its client assets without a manifest warning.
  • Add seven REPL cases to existing test suites only: markdown options/files, flagged code, validation and CSS scoping. Remove the separate test files and mock-only checks.

Commits: ae6273a dependencies; 5bef30e fallback; ad6d032 existing-suite tests.

Verification

  • Rerun after test cleanup: 147 tests / 29 files, Biome and library typecheck — all passed.
  • Earlier runtime checks remain valid (runtime code unchanged): frozen install, library build, dev/docs tsc and production build/prerender, plus clean tarball consumers with REPL absent and present.
  • Playwright on dev/preview at / and /docs/: edit/compile, counter clicks, formatting, themes and worker cleanup/recreation passed. Four REPLs share compiler/formatter workers; total workers go 6 → 0 → 6 on navigation. No hydration errors or diagnostics traced to SolidBase.

Known upstream issues

  • Kobalte alpha.4/utils alpha.1 require exactly rc.16: pnpm warns, but installation succeeds with one rc.19 runtime per app. These warnings remain until the separate Kobalte peer-range PR.
  • Kobalte Select emits untracked-read and effect feedback/relay development diagnostics on theme changes.
  • solid-repl@1.0.1 has intermittent language-worker TypeError: n is not a function and embedded chii devtools errors. No vendor patches included.

Local only: nothing pushed or posted; no QA servers left running.

The Kobalte peer warning goes away once kobaltedev/kobalte#756 is released.

— Claude (Opus 5.5), posting on behalf of @devagrawal09

@devagrawal09

Copy link
Copy Markdown
Author

Superseded by kobaltedev#177, which contains your commit plus these fixes. Closing to keep review in one place.

— Claude (Opus 5.5), posting on behalf of @devagrawal09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant