Repository navigation
Conversation
Co-authored-by: Fedor Sakharov <fedor.sakharov@gmail.com>
Fall back to the environment passed to NVCC when dry-run output omits PATH, while preserving explicit dry-run overrides. Return executable lookup errors instead of panicking when PATH is absent.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3009 +/- ##
==========================================
- Coverage 78.81% 78.34% -0.48%
==========================================
Files 75 75
Lines 45354 46826 +1472
==========================================
+ Hits 35745 36684 +939
- Misses 9609 10142 +533 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Nov 9, 2026
…rp-migration-2241
…rp-migration-2241
There was a problem hiding this comment.
🟡 Changes recommended
Blocking build/cache operations and unbounded upload buffering risk server stalls and memory exhaustion, while Accept negotiation and upload timing introduce compatibility and job-expiration regressions.
1 open issue
What changed in this PR
Migrates sccache’s distributed HTTP services from Rouille to Warp, continuing the cachepot port tracked in #1620 and superseding #2241.
Changes:
- Converts distributed handlers, authentication requests, and server startup to async execution.
- Adds HTTP regression tests and adapts distributed integration tests to Tokio.
- Also fixes NVCC executable lookup when dry-run output omits PATH, with regression tests.
| File | Description |
|---|---|
tests/harness/mod.rs |
Uses async server tasks, HTTP checks, and readiness polling. |
tests/dist.rs |
Converts distributed tests to async execution and serializes them. |
src/util.rs |
Replaces the blocking HTTP client helper with an async client. |
src/lib.rs |
Removes the Rouille macro import. |
src/dist/mod.rs |
Updates distributed traits and reader bounds for async handlers. |
src/dist/http.rs |
Implements Warp routes, async requests, and HTTP regression tests. |
src/dist/client_auth.rs |
Makes OAuth token exchange asynchronous. |
src/compiler/nvcc.rs |
Adds inherited PATH fallback and executable-lookup tests. |
src/bin/sccache-dist/token_check.rs |
Converts remote token checks to async and adds tests. |
src/bin/sccache-dist/main.rs |
Integrates Tokio runtimes and async distributed handlers. |
Cargo.toml |
Replaces Rouille with Warp and updates dependency features. |
Cargo.lock |
Records the updated dependency graph. |
Review effort: Balanced
| .unwrap_or(SubmitToolchainResult::CannotCache)) | ||
| } | ||
| fn handle_run_job( | ||
| async fn handle_run_job( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Replaces
rouillewithwarpas our primary request/response handler framework.Part of porting changes from cachepot #1620
The original PR is here paritytech/cachepot#131
Supersedes #2241 with all fixes included.
Initial porting was done by @Saruniks
Original work was done by @montekki