Repository navigation
Conversation
Fall back to the environment passed to NVCC when dry-run output omits PATH, while preserving explicit dry-run overrides. Return executable lookup errors instead of panicking when PATH is absent.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3012 +/- ##
==========================================
+ Coverage 78.81% 78.84% +0.03%
==========================================
Files 75 75
Lines 45354 45433 +79
==========================================
+ Hits 35745 35823 +78
- Misses 9609 9610 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Nov 9, 2026
There was a problem hiding this comment.
🟡 Changes recommended
The case-sensitive PATH lookup ignores inherited Path on Windows, causing bare compiler names to remain unresolved when the dry run omits PATH.
1 open issue
What changed in this PR
Updates NVCC dry-run parsing to support distributions that omit PATH assignments, using the environment passed to NVCC for executable lookup.
Changes:
- Falls back to inherited PATH while preserving explicit dry-run overrides.
- Returns executable lookup errors instead of panicking when PATH is absent.
- Adds tests for PATH fallback, override precedence, absolute executable paths, and missing-PATH errors.
| File | Description |
|---|---|
src/compiler/nvcc.rs |
Updates subcommand executable lookup and adds regression tests. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
sylvestre
reviewed
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fall back to the environment passed to NVCC when dry-run output omits PATH, while preserving explicit dry-run overrides. Return executable lookup errors instead of panicking when PATH is absent.
So the core issue is the missing
$# PATHwhich is not present in all distributions, hence we also use theinherited_env_varswe (the sccache wrapper process) pass to thenvccbinary and also search that.