Skip to content

Reject invalid calibration and unsafe native deadlines - #21

Closed
han-xudong wants to merge 3 commits into
mainfrom
codex/ecosystem-improvements
Closed

han-xudong wants to merge 3 commits into
mainfrom
codex/ecosystem-improvements

Conversation

@han-xudong

@han-xudong han-xudong commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Calibration and duration edge cases can currently produce non-finite values or unsafe native deadlines. This change rejects out-of-range calibration before delivery, checks duration/deadline conversions, and documents the uncancellable DNS boundary.

The four consumers pin this SDK candidate and retain their private build adapters. Numerical, transport/lifecycle and bounded resolver regressions passed locally; the fixed five-input parser corpus also passed ASan/UBSan. This draft runs the existing platform acceptance before review. No hardware configuration writes or release publication are involved.

Superseded by #22 after the source branch was renamed to fix/ecosystem-improvements. The implementation commit is unchanged; this closed PR retains the original discussion and acceptance history.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.51020% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/types.cpp 77.27% 2 Missing and 3 partials ⚠️
src/detail/client_impl.cpp 72.72% 1 Missing and 2 partials ⚠️
src/detail/time.hpp 75.00% 1 Missing and 2 partials ⚠️
src/detail/xml_config.cpp 66.66% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant