Repository navigation
Retain reviewed source in immutable native bindings (#1017) - #1254
Conversation
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Merged as The Core API slice is complete: optional Work2 owns population before publication; Lead owns complete-binding consumers, frozen task/checkpoint and checkout fences. Their composed runtime acceptance remains separate. This does not claim the entire native board row complete or activate helpers. #1097's additional execution-policy qualification continues independently. |
Feature A (#1214), T3. Implements #1017's admitted reviewed-source extension for #307's night-watch/feeder row, following board comments 6964494276 and 6965162966.
PR admission needs the revalidated reviewed head to survive reopening its protected receipt.
NativeBindingnow carries optionalreviewed_head, with serde default/omitted None for old issue rows. Existingnew(number, key, &lease, branch)remains unchanged.new_reviewed(number, key, &lease, branch, reviewed_head)uses the existing full lowercase 40/64-character object-ID validator; publicvalidate(&self) -> Result<()>validates the complete receipt. These live inoxa/oxa-work/src/board/claims/native.rsand are exposed throughoxa_work::board::NativeBinding.The existing protected Claims row, lock, atomic writer, full original lease CAS and retained-binding equality remain the only authority. A retained head cannot change, disappear or be added later in the same lease. Native IDs stay board/key/generation based. Work2 alone populates the revalidated Prepared PR revision before the ready hardlink; Lead alone freezes it and applies checkout fences. No caller or execution changes in this PR.
Validation:
fe6385f1, run 44207924025: supplied real-binary runtime evidence reaches PR admission/publication/reopening, then fails work_refill_cli.rs:221 because the reviewed revision was not retained; ARM 1,519/1,520 passed and issue controls passed first.f68f274d, lane 44208998978 failed at runtime: ARM 1,505/1,506 passed; the new reviewed admission decode fails on the unsupported reviewed_head field. Legacy issue encoding control passes. This is not a compiler failure.99804ce10beca6701efc2487392f926327c6c1eb: lane 44210568596 SUCCESS, selectingoxa-cli,oxa-parityandoxa-workon x86_64 and ARM64. Ready full required CI 44210820805 SUCCESS; every required check name is pass/expected skip, including mandatory sandbox tests, clippy and scans.b5e321ba96695127a92c6e1b1d76673bdd779e4a; merge-group integration 44212619639 passed on that exact landed commit.Removes: nothing. No second store, authority, helper activation, caller edits or ownership handover. Existing Core1173/1220 and lifecycle histories are preserved. Branch
agent/1017-reviewed-native-bindingstarts from published main5cbccf25.