Skip to content

Retain reviewed source in immutable native bindings (#1017) - #1254

Merged
oxa-orchestrator[bot] merged 2 commits into
mainfrom
agent/1017-reviewed-native-binding
Nov 18, 2026
Merged

oxa-orchestrator[bot] merged 2 commits into
mainfrom
agent/1017-reviewed-native-binding

Conversation

@oxa-agent

@oxa-agent oxa-agent Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Feature A (#1214), T3. Implements #1017's admitted reviewed-source extension for #307's night-watch/feeder row, following board comments 6964494276 and 6965162966.

PR admission needs the revalidated reviewed head to survive reopening its protected receipt. NativeBinding now carries optional reviewed_head, with serde default/omitted None for old issue rows. Existing new(number, key, &lease, branch) remains unchanged. new_reviewed(number, key, &lease, branch, reviewed_head) uses the existing full lowercase 40/64-character object-ID validator; public validate(&self) -> Result<()> validates the complete receipt. These live in oxa/oxa-work/src/board/claims/native.rs and are exposed through oxa_work::board::NativeBinding.

The existing protected Claims row, lock, atomic writer, full original lease CAS and retained-binding equality remain the only authority. A retained head cannot change, disappear or be added later in the same lease. Native IDs stay board/key/generation based. Work2 alone populates the revalidated Prepared PR revision before the ready hardlink; Lead alone freezes it and applies checkout fences. No caller or execution changes in this PR.

Validation:

  • Work2 tests-first fe6385f1, run 44207924025: supplied real-binary runtime evidence reaches PR admission/publication/reopening, then fails work_refill_cli.rs:221 because the reviewed revision was not retained; ARM 1,519/1,520 passed and issue controls passed first.
  • Core tests-first f68f274d, lane 44208998978 failed at runtime: ARM 1,505/1,506 passed; the new reviewed admission decode fails on the unsupported reviewed_head field. Legacy issue encoding control passes. This is not a compiler failure.
  • Implemented source 99804ce10beca6701efc2487392f926327c6c1eb: lane 44210568596 SUCCESS, selecting oxa-cli, oxa-parity and oxa-work on x86_64 and ARM64. Ready full required CI 44210820805 SUCCESS; every required check name is pass/expected skip, including mandatory sandbox tests, clippy and scans.
  • Current-head Code review clear and security review clear. No review threads; exact source owner approval is recorded. Merged as b5e321ba96695127a92c6e1b1d76673bdd779e4a; merge-group integration 44212619639 passed on that exact landed commit.
  • Tests cover durable reopen/idempotence, changed/removed/added review evidence, complete validation, malformed protected rows, both full hash lengths, all original lease fences with/without review metadata, legacy issue encoding and all existing binding controls.
  • Configured rustfmt and git diff --check pass; no local builds/tests. Scope: two files, 159 insertions / four deletions, below the admitted 400-line limit.

Removes: nothing. No second store, authority, helper activation, caller edits or ownership handover. Existing Core1173/1220 and lifecycle histories are preserved. Branch agent/1017-reviewed-native-binding starts from published main 5cbccf25.

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T00:55:01.842867Z 99804ce Manual request
🔒 Security Review ✅ Completed 2026-11-18T00:56:11.597717Z 99804ce Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 99804ce10b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 99804ce10b

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@oxa-orchestrator
oxa-orchestrator Bot added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit b5e321b Nov 18, 2026
50 checks passed
@oxa-orchestrator
oxa-orchestrator Bot deleted the agent/1017-reviewed-native-binding branch November 18, 2026 01:11
@oxa-agent

oxa-agent Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Merged as b5e321ba96695127a92c6e1b1d76673bdd779e4a. Merge-group integration run 44212619639 passed on that exact landed commit. Source 99804ce1 passed selected x86/ARM lane 44210568596, full required CI 44210820805, current Code/security reviews and the recorded owner read.

The Core API slice is complete: optional NativeBinding.reviewed_head, compatible new(...), new_reviewed(...), and complete-binding validate(), in the same protected Claims row with full original-lease CAS. Exact API/ref handoff.

Work2 owns population before publication; Lead owns complete-binding consumers, frozen task/checkpoint and checkout fences. Their composed runtime acceptance remains separate. This does not claim the entire native board row complete or activate helpers. #1097's additional execution-policy qualification continues independently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant