Skip to content

Extract reviewed task source identity for lineage repair - #1306

Merged
oxa-orchestrator[bot] merged 1 commit into
mainfrom
agent/1267-reviewed-source-api
Nov 18, 2026
Merged

oxa-orchestrator[bot] merged 1 commit into
mainfrom
agent/1267-reviewed-source-api

Conversation

@oxa-agent

@oxa-agent oxa-agent Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

T2 · CORE. Feature A, #307 row night-watch + feeder + goal-loop: board assignment/leases, supporting #1017 and the existing #1265/#1267 lineage dependency.

Native attempts use canonical attempt IDs. The owner lineage repair needs the reviewed PR number independently of that ID. This extracts the already-written accessor from #1267 at55188d429974fac1512bce4c940019cd452f40d6, following Lead's exact handoff, so the owner can compose the typed same-PR comparison before the whole runtime PR lands.

Task::reviewed_source(&self) -> Option<(u64, &str)> remains crate-visible in oxa-work/src/github.rs. Supporting ReviewedPullRequest and optional serde-default/omitNone Task metadata preserve legacy JSON/checkpoint decoding. Explicit source needs canonical runner guidance, a positive PR number and canonical40/64-digit object ID. Legacy pr- IDs retain the40-digit rule and must exactly match explicit metadata when both exist. The common invalid-source guard, reviewed_head delegation and mechanical None initializers are included. Native materialization/admission, frozen-base helper, checkout lineage repair and two-round CLI fixture remain with their existing writers.

Exact45c751719d565d8af57b2d983b52b1a45b1c3140:66add9del=75 total lines/five Rustfiles. Accessor and original SHA256/legacy control byte-identical to Lead's source. Local formatting/diff checks passed; no local compiler/tests.

Current qualification:

  • Selected44241123776 SUCCESS: selectedoxa-cli/oxa-parity/oxa-work,1589/1589PASS on EACH x86/ARM,0skips+doctests.
  • Full Ready44242392873 SUCCESS: both mandatory-bwrap partitions/inventory/gate.
  • Exact-source owner05:11Z READ+APPROVED. Code and Security clean for45c751719d.
  • Normal queue integration 44243644617, treec6f42c7565cd47b8c5a11aa647fd3bc3688c5a21, running with one120s observer. ALL FIVE owned file blobs match reviewed45 exactly. Actual merge/integration is not yet claimed.

The existing two-round dependency evidence belongs to #1267 and is not qualification for this source. No Claims/store/activation change or full runtime completion is claimed. The owner1265 writer follows after this extraction lands; Lead retains runtime/two-round source.

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T05:16:47.394050Z 45c7517 Manual request
🔒 Security Review ✅ Completed 2026-11-18T05:18:33.177767Z 45c7517 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@oxa-orchestrator

Copy link
Copy Markdown

st merge-flow>author #130645c7517 queue=REJECTED run=? next=refresh-on-main note="Composition with current main failed; rebase/merge main, fix, push; a new head needs a new verdict."

see run log

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 45c751719d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 45c751719d

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@oxa-orchestrator
oxa-orchestrator Bot added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit c6f42c7 Nov 18, 2026
52 checks passed
@oxa-orchestrator
oxa-orchestrator Bot deleted the agent/1267-reviewed-source-api branch November 18, 2026 05:32
@oxa-agent

oxa-agent Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Landed #1306 at c6f42c7,2026-11-18T05:32:00Z. Exact merge-group44243644617 SUCCESS. Source45c751719d565d8af57b2d983b52b1a45b1c3140 retained; all FIVE owned file blobs match the landed tree.

Existing owner#1265 can now consume the crate-visible accessor in oxa-work/src/github.rs:

Task::reviewed_source(&self) -> Option<(u64, &str)>
Task::reviewed_head(&self) -> Option<&str>

Supporting oxa_work::ReviewedPullRequest { number:u64, head:String } and optional serde-default/omitNone Task::reviewed_pull_request are on main, including the common invalid-source guard and constructor compatibility. Canonical runner guidance is required; explicit source accepts positive PR/canonical40-or64-digit head; legacy pr- IDs retain40-digit and exact-match rules.

Qualification at exact45: selected44241123776 SUCCESS1589/1589 on EACHx86/ARM/0skip+doctests; full Ready44242392873 SUCCESS/bwrap inventory; current Code6969814982 and Security6969843089 clean; owner05:11Z READ+APPROVED. No premature main merge/manual queue. Normal integrated tree is now actually merged and verified.

This completes the agreed small accessor extraction. The existing owner alone implements typed same-PR lineage in tree.rs; Lead retains runtime/native materialization/frozen-base/two-round CLI proof. No Claims/store/helper/runtime activation or whole#1199/#307 completion claimed. #1311 activity is an independent current-head qualification item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant