Repository navigation
Extract reviewed task source identity for lineage repair - #1306
Conversation
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Landed #1306 at c6f42c7,2026-11-18T05:32:00Z. Exact merge-group44243644617 SUCCESS. Source45c751719d565d8af57b2d983b52b1a45b1c3140 retained; all FIVE owned file blobs match the landed tree. Existing owner#1265 can now consume the crate-visible accessor in oxa-work/src/github.rs: Supporting oxa_work::ReviewedPullRequest { number:u64, head:String } and optional serde-default/omitNone Task::reviewed_pull_request are on main, including the common invalid-source guard and constructor compatibility. Canonical runner guidance is required; explicit source accepts positive PR/canonical40-or64-digit head; legacy pr- IDs retain40-digit and exact-match rules. Qualification at exact45: selected44241123776 SUCCESS1589/1589 on EACHx86/ARM/0skip+doctests; full Ready44242392873 SUCCESS/bwrap inventory; current Code6969814982 and Security6969843089 clean; owner05:11Z READ+APPROVED. No premature main merge/manual queue. Normal integrated tree is now actually merged and verified. This completes the agreed small accessor extraction. The existing owner alone implements typed same-PR lineage in tree.rs; Lead retains runtime/native materialization/frozen-base/two-round CLI proof. No Claims/store/helper/runtime activation or whole#1199/#307 completion claimed. #1311 activity is an independent current-head qualification item. |
T2 · CORE. Feature A, #307 row night-watch + feeder + goal-loop: board assignment/leases, supporting #1017 and the existing #1265/#1267 lineage dependency.
Native attempts use canonical attempt IDs. The owner lineage repair needs the reviewed PR number independently of that ID. This extracts the already-written accessor from #1267 at55188d429974fac1512bce4c940019cd452f40d6, following Lead's exact handoff, so the owner can compose the typed same-PR comparison before the whole runtime PR lands.
Task::reviewed_source(&self) -> Option<(u64, &str)> remains crate-visible in oxa-work/src/github.rs. Supporting ReviewedPullRequest and optional serde-default/omitNone Task metadata preserve legacy JSON/checkpoint decoding. Explicit source needs canonical runner guidance, a positive PR number and canonical40/64-digit object ID. Legacy pr- IDs retain the40-digit rule and must exactly match explicit metadata when both exist. The common invalid-source guard, reviewed_head delegation and mechanical None initializers are included. Native materialization/admission, frozen-base helper, checkout lineage repair and two-round CLI fixture remain with their existing writers.
Exact45c751719d565d8af57b2d983b52b1a45b1c3140:66add9del=75 total lines/five Rustfiles. Accessor and original SHA256/legacy control byte-identical to Lead's source. Local formatting/diff checks passed; no local compiler/tests.
Current qualification:
The existing two-round dependency evidence belongs to #1267 and is not qualification for this source. No Claims/store/activation change or full runtime completion is claimed. The owner1265 writer follows after this extraction lands; Lead retains runtime/two-round source.