Repository navigation
Record lease activity separately from heartbeat observations - #1311
Conversation
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
#1311 landed at 8c27af1,2026-11-18T05:59:07Z. Exact merge-group44247008013 SUCCESS; all SIX owned file blobs match sourcec5f004af51a109d86dc13da4f42e4807657bd61c. The exact Core signal API and recovery contract are now on main: LeaseSignal::{Heartbeat,Milestone(&Record,original_launch_revision)}, LeaseActivity/VerifiedMilestone, Claims::observe_item_for and Assignment::stalled. The original runner-owned pre-spawn launch revision persists with the actual process result per Lead's contract. Metadata/new finish revisions and heartbeat do not certify new action. Qualification: selected44244208130 SUCCESS1591/1591 on EACHx86/ARM,0skips+doctests; fullReady44245853705 SUCCESS/both bwrap partitions/inventory/gate; Code6970244688+Security6970263237 clean; Owner05:35Z exact-source READ+APPROVED. All single observers consumed, no CI restart or premature main merge. Lead owns actual capture/persistence/child observation and runtime wiring. Work2 owns isolated real-CLI controls. This landing qualifies the Core data/rules only; no runtime activation, whole#1199 acceptance or helper start is claimed. The typed-wait foundation fd60d27 passed1594 tests per architecture; its main-based PR follows reconciliation of the actual dependent-branch conflicts. The bounded atomic resume/wake delta7d8b30ee remains separate. |
T3 · CORE. Feature A, #1199 item1 and #307 row night-watch + feeder + goal-loop: board assignment/leases. This first bounded slice records per-lease verified actions separately from heartbeat; typed dependency/yield/resume and sampling policy follow separately. Lead keeps production signals; Work2 keeps the isolated real-CLI lifecycle file.
A live child can remain silent, so a heartbeat must not reset the work-progress clock. Add optional activity to the existing protected AssignmentData row, using the current full ItemLease/host/renewed-expiry receipt and complete immutable NativeBinding under the same Claims lock. Silence assessment is configurable/default-off; heartbeat never counts as action and a stalled result cannot release ownership. Existing current receipt, renewed expiry, Owner/Lead and verified exact holder/host-gone reclaim remain required.
The agreed signal contract reuses Lead's existing durable pre-spawn checkpoint revision, persisted alongside the actual process result in Lead's existing record.
LeaseSignal::Milestone(&Record, launch_revision)requires the exact bound attempt/branch, typed WorkerFinished result at Acceptance/Recheck, positive launch revision before finish, and original durable timestamp. A subsequent action requires a launch and finish newer than the previous finish. Replay or a cached result with a fresh finish revision/time retains its old launch identity and stays quiet. Metadata/accounting/restart/publishing retries and heartbeat never certify action. Old checkpoints without launch identity provide no action signal.Tests cover heartbeat-only silence, fractional-millisecond deadlines, exact replay and rewrapped cached results, a distinct later process that advances progress, metadata/foreign-record suppression, invalid launch/time/timeout values, wrong host/full binding, stale renewal/release/reassignment receipts, and verified-expiry/gone reclaim. Original binding/Lease/attempts are preserved; new admission clears old activity. No task/repository lock reacquisition, raw checkpoint detail/transcript storage, second store, runtime wiring or activation.
Current source c5f004a: 383 additions + 3 deletions = 386 total lines, six Rust files; all prior controls retained. Formatting and
git diff --checkpassed locally; no local compiler/tests. Selected lane44244208130 is running on this exact head with one120s observer. Earlier Record-only213 is superseded and is not final qualification. Full required CI, current connected Code/security and the new exact-source read remain gates; no #1306 approval carry.