Skip to content

Record lease activity separately from heartbeat observations - #1311

Merged
oxa-orchestrator[bot] merged 2 commits into
mainfrom
agent/1199-lease-activity
Nov 18, 2026
Merged

oxa-orchestrator[bot] merged 2 commits into
mainfrom
agent/1199-lease-activity

Conversation

@oxa-agent

@oxa-agent oxa-agent Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

T3 · CORE. Feature A, #1199 item1 and #307 row night-watch + feeder + goal-loop: board assignment/leases. This first bounded slice records per-lease verified actions separately from heartbeat; typed dependency/yield/resume and sampling policy follow separately. Lead keeps production signals; Work2 keeps the isolated real-CLI lifecycle file.

A live child can remain silent, so a heartbeat must not reset the work-progress clock. Add optional activity to the existing protected AssignmentData row, using the current full ItemLease/host/renewed-expiry receipt and complete immutable NativeBinding under the same Claims lock. Silence assessment is configurable/default-off; heartbeat never counts as action and a stalled result cannot release ownership. Existing current receipt, renewed expiry, Owner/Lead and verified exact holder/host-gone reclaim remain required.

The agreed signal contract reuses Lead's existing durable pre-spawn checkpoint revision, persisted alongside the actual process result in Lead's existing record. LeaseSignal::Milestone(&Record, launch_revision) requires the exact bound attempt/branch, typed WorkerFinished result at Acceptance/Recheck, positive launch revision before finish, and original durable timestamp. A subsequent action requires a launch and finish newer than the previous finish. Replay or a cached result with a fresh finish revision/time retains its old launch identity and stays quiet. Metadata/accounting/restart/publishing retries and heartbeat never certify action. Old checkpoints without launch identity provide no action signal.

Tests cover heartbeat-only silence, fractional-millisecond deadlines, exact replay and rewrapped cached results, a distinct later process that advances progress, metadata/foreign-record suppression, invalid launch/time/timeout values, wrong host/full binding, stale renewal/release/reassignment receipts, and verified-expiry/gone reclaim. Original binding/Lease/attempts are preserved; new admission clears old activity. No task/repository lock reacquisition, raw checkpoint detail/transcript storage, second store, runtime wiring or activation.

Current source c5f004a: 383 additions + 3 deletions = 386 total lines, six Rust files; all prior controls retained. Formatting and git diff --check passed locally; no local compiler/tests. Selected lane44244208130 is running on this exact head with one120s observer. Earlier Record-only213 is superseded and is not final qualification. Full required CI, current connected Code/security and the new exact-source read remain gates; no #1306 approval carry.

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T05:43:34.950362Z c5f004a Manual request
🔒 Security Review ✅ Completed 2026-11-18T05:44:43.195467Z c5f004a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@oxa-orchestrator
oxa-orchestrator Bot enabled auto-merge November 18, 2026 05:42
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: c5f004af51

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: c5f004af51

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@oxa-orchestrator

Copy link
Copy Markdown

st merge-flow>author #1311c5f004a queue=REJECTED run=? next=refresh-on-main note="Composition with current main failed; rebase/merge main, fix, push; a new head needs a new verdict."

see run log

@oxa-orchestrator
oxa-orchestrator Bot added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 8c27af1 Nov 18, 2026
52 checks passed
@oxa-orchestrator
oxa-orchestrator Bot deleted the agent/1199-lease-activity branch November 18, 2026 05:59
@oxa-agent

oxa-agent Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

#1311 landed at 8c27af1,2026-11-18T05:59:07Z. Exact merge-group44247008013 SUCCESS; all SIX owned file blobs match sourcec5f004af51a109d86dc13da4f42e4807657bd61c.

The exact Core signal API and recovery contract are now on main: LeaseSignal::{Heartbeat,Milestone(&Record,original_launch_revision)}, LeaseActivity/VerifiedMilestone, Claims::observe_item_for and Assignment::stalled. The original runner-owned pre-spawn launch revision persists with the actual process result per Lead's contract. Metadata/new finish revisions and heartbeat do not certify new action.

Qualification: selected44244208130 SUCCESS1591/1591 on EACHx86/ARM,0skips+doctests; fullReady44245853705 SUCCESS/both bwrap partitions/inventory/gate; Code6970244688+Security6970263237 clean; Owner05:35Z exact-source READ+APPROVED. All single observers consumed, no CI restart or premature main merge.

Lead owns actual capture/persistence/child observation and runtime wiring. Work2 owns isolated real-CLI controls. This landing qualifies the Core data/rules only; no runtime activation, whole#1199 acceptance or helper start is claimed. The typed-wait foundation fd60d27 passed1594 tests per architecture; its main-based PR follows reconciliation of the actual dependent-branch conflicts. The bounded atomic resume/wake delta7d8b30ee remains separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant