Repository navigation
feat: map the Systems Manager response members from the 1.74.0 gap report - #418
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 6 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This was referenced Sep 9, 2026
Merged
danielabbatt
force-pushed
the
feat/map-organizations-members
branch
from
September 29, 2026 12:15
469bd04 to
7b01747
Compare
danielabbatt
force-pushed
the
feat/map-sm-members
branch
from
September 29, 2026 12:15
ad0a3fd to
ae65d27
Compare
danielabbatt
force-pushed
the
feat/map-organizations-members
branch
from
September 29, 2026 12:43
7b01747 to
3d0d624
Compare
danielabbatt
force-pushed
the
feat/map-sm-members
branch
from
September 29, 2026 12:43
ae65d27 to
25da283
Compare
danielabbatt
force-pushed
the
feat/map-organizations-members
branch
from
September 29, 2026 12:52
3d0d624 to
6a7aa02
Compare
danielabbatt
force-pushed
the
feat/map-sm-members
branch
from
September 29, 2026 12:52
25da283 to
3cd4312
Compare
…port
Nineteen members the v1.74.0 spec documents that the models lacked, the
second per-area batch. SmVppAccount gains the thirteen fields the API
returns beyond id and vppServiceToken, with ParsedToken backed by a new
SmVppAccountParsedToken. SmProfile.PayloadTypes and
SmTrustedAccessConfig.TimeboundType are added.
ModifyNetworkSmDevicesTagsAsync now returns List<SmDevicesModifyTagsResponse>.
It was declared as List<SmDevicesCheckinRequest>, the request type, none of
whose members the response contains, so each device came back as an empty
object. Checkin and Lock keep the request type because their {ids} response
binds to it.
SmMemberTests covers the new members and the corrected return type.
danielabbatt
force-pushed
the
feat/map-organizations-members
branch
from
September 29, 2026 12:56
6a7aa02 to
ffe8209
Compare
danielabbatt
force-pushed
the
feat/map-sm-members
branch
from
September 29, 2026 12:56
3cd4312 to
73b81bd
Compare
danielabbatt
changed the base branch from
feat/map-organizations-members
to
main
September 29, 2026 13:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #417, in the chain that starts at #415
Base is
feat/map-organizations-members. Merge #415, #416 and #417 first (merge commits), then retarget this tomain. Changelog label1.74.8assumes that order.What
The second per-area batch from
gap-report-v1.74.0.md: 19 Systems Manager members the spec documents that the models lacked.SmVppAccountid/vppServiceToken, incl.ParsedToken(newSmVppAccountParsedToken:OrgName,HashedToken,ExpiresAt)SmProfilePayloadTypesSmTrustedAccessConfigTimeboundTypeOne correction (breaking)
ModifyNetworkSmDevicesTagsAsyncwas declared asTask<List<SmDevicesCheckinRequest>>, the request type. The API returns[{id, serial, wifiMac, tags}], none of which the request type has, so every device came back as an empty object. It now returnsTask<List<SmDevicesModifyTagsResponse>>.CheckinNetworkSmDevicesAsyncandLockNetworkSmDevicesAsyncalso return the request type, but their{ids}response does bind to it, so they are left alone.Not in this PR
Seven
DeviceLiveTools*members my area filter caught belong to LiveTools/General and will land with that batch.Verification
Edited files kept their BOM state. No code outside
Interfaces/Datareferenced the changed method.