Skip to content

feat: map the Systems Manager response members from the 1.74.0 gap report - #418

Merged
danielabbatt merged 1 commit into
mainfrom
feat/map-sm-members
Sep 29, 2026
Merged

danielabbatt merged 1 commit into
mainfrom
feat/map-sm-members

Conversation

@danielabbatt

@danielabbatt danielabbatt commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Rebased onto main on 2026-09-29 (main builds as 1.70.147). Merges as 1.74.8.

Before merging, retarget the base to main. Base branches are not auto-deleted in this repo, so GitHub will not retarget for you, and merging into the old base leaves the work off main (what happened to #413). Merge only after #417 is on main, with a merge commit; do not squash, rebase or click Update branch.

Stacked on #417, in the chain that starts at #415

Base is feat/map-organizations-members. Merge #415, #416 and #417 first (merge commits), then retarget this to main. Changelog label 1.74.8 assumes that order.

What

The second per-area batch from gap-report-v1.74.0.md: 19 Systems Manager members the spec documents that the models lacked.

Model Added
SmVppAccount 13 fields the API returns beyond id/vppServiceToken, incl. ParsedToken (new SmVppAccountParsedToken: OrgName, HashedToken, ExpiresAt)
SmProfile PayloadTypes
SmTrustedAccessConfig TimeboundType

One correction (breaking)

ModifyNetworkSmDevicesTagsAsync was declared as Task<List<SmDevicesCheckinRequest>>, the request type. The API returns [{id, serial, wifiMac, tags}], none of which the request type has, so every device came back as an empty object. It now returns Task<List<SmDevicesModifyTagsResponse>>.

CheckinNetworkSmDevicesAsync and LockNetworkSmDevicesAsync also return the request type, but their {ids} response does bind to it, so they are left alone.

Not in this PR

Seven DeviceLiveTools* members my area filter caught belong to LiveTools/General and will land with that batch.

Verification

dotnet build Meraki.Api.slnx -c Debug   Build succeeded, 0 Error(s), 6 pre-existing CS0618 warnings
Meraki.Api.Test (Data namespace)        Total: 34, Errors: 0, Failed: 0   (4 new in SmMemberTests)
Meraki.Api.Test (Workflows)             Total: 12, Errors: 0, Failed: 0

Edited files kept their BOM state. No code outside Interfaces/Data referenced the changed method.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 6 complexity

Metric Results
Complexity 6

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

…port

Nineteen members the v1.74.0 spec documents that the models lacked, the
second per-area batch. SmVppAccount gains the thirteen fields the API
returns beyond id and vppServiceToken, with ParsedToken backed by a new
SmVppAccountParsedToken. SmProfile.PayloadTypes and
SmTrustedAccessConfig.TimeboundType are added.

ModifyNetworkSmDevicesTagsAsync now returns List<SmDevicesModifyTagsResponse>.
It was declared as List<SmDevicesCheckinRequest>, the request type, none of
whose members the response contains, so each device came back as an empty
object. Checkin and Lock keep the request type because their {ids} response
binds to it.

SmMemberTests covers the new members and the corrected return type.
@danielabbatt
danielabbatt force-pushed the feat/map-organizations-members branch from 6a7aa02 to ffe8209 Compare September 29, 2026 12:56

@danielabbatt danielabbatt left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@danielabbatt
danielabbatt changed the base branch from feat/map-organizations-members to main September 29, 2026 13:59
@danielabbatt
danielabbatt merged commit edb1f57 into main Sep 29, 2026
1 check passed
@danielabbatt
danielabbatt deleted the feat/map-sm-members branch September 29, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant