Bind coordinated MySQL query operations - #28
Merged
Merged
Conversation
This was referenced Sep 21, 2026
alexstandiford
changed the base branch from
codex/pdo-coordinated-operations
to
main
September 21, 2026 01:31
alexstandiford
changed the base branch from
main
to
codex/pdo-coordinated-operations
September 21, 2026 01:31
alexstandiford
changed the base branch from
codex/pdo-coordinated-operations
to
main
September 28, 2026 18:00
alexstandiford
marked this pull request as ready for review
September 28, 2026 18:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This adds the MySQL query layer above the PDO coordinator from PR 22.
e3f0146ced3238a36b0c1e3db53eb3b5b46392abincludes currentmain, which carries the already merged operation-bound formatting and predicate validation changes.Review dependency
phpnomad/dbis pinned to PR 42 head4b0b7709e5945a4290b04c2e3562ef919923ed08. This is a temporary review dependency forCoordinatedQueryStrategy,OperationQueryStrategy,OperationDatabaseHandlerBridge, andOperationDatabaseProviderFactory.PR 25 remains separate. The operation-local insert path formats its columns through the active backend because it cannot safely depend on a global formatter.
Proof
Against an isolated MySQL 8.4.11 server:
The bridge tests cover fresh reads despite a stale shared-cache value, commit, rollback of multiple writes and read-after-write, one callback invocation, undeclared-table refusal, expired-handle refusal, builder independence, publication suppression during the transaction, publication after commit, and clause construction through the exact operation resource. A poison global formatter makes resource escape fail.
Other checks:
libandtestsNo merge, release, tag, or deployment is included.