Repository navigation
Conversation
Refs robotiq/robotiq-ros#114. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mbegin-robotiq
left a comment
mbegin-robotiq
left a comment
There was a problem hiding this comment.
LGTM. The rename is complete (no stray robotiq/ros left besides the test fixture). One follow-up to handle about Stable link rewriting, see inline.
| ]), | ||
|
|
||
| ...submoduleJobs('robotiq_ros', { repoUrl: 'https://github.com/robotiq/ros', branch: 'main' }, [ | ||
| ...submoduleJobs('robotiq_ros', { repoUrl: 'https://github.com/robotiq/robotiq-ros', branch: 'main' }, [ |
There was a problem hiding this comment.
Heads-up: this changes what rewriteMainLinksToTag (scripts/cut-version.js:110) matches, and Stable is re-materialized on every build from software-tools-stable.json, which pins adaptive-grippers-ros/tactile-ros to v1.3.0. The README at v1.3.0 (and at the current pin 77ba6fd, and on main) still uses https://github.com/robotiq/ros (5 bare links + one /tree/main), so once this merges none of them get rewritten to /tree/v1.3.0 anymore. Stable silently goes back to pointing at main through the redirect. Merging after robotiq/robotiq-ros#143 doesn't help, since tags are immutable.
Two options:
- Add an alias, e.g.
repoUrlAliases: ['https://github.com/robotiq/ros'], and have the rewrite match both prefixes (emitting the new URL), plus a case intest/cut-version.test.js. This also covers any future re-cut at an older tag. - Or tag a v1.3.1 on robotiq-ros after #143 and bump
software-tools-stable.jsonin the same PR.
I'd go with 1. Fine as a follow-up.
| [submodule "external/robotiq_ros"] | ||
| path = external/robotiq_ros | ||
| url = https://github.com/robotiq/ros | ||
| url = https://github.com/robotiq/robotiq-ros |
There was a problem hiding this comment.
Nit: once robotiq/robotiq-ros#143 lands, consider bumping the external/robotiq_ros pin (here or via Dependabot). Until then, Latest mixes robotiq-ros URLs (built from relative links) with the README's own robotiq/ros links. Both work thanks to the redirect, so it's cosmetic only.
bcastets-robotiq
left a comment
bcastets-robotiq
left a comment
There was a problem hiding this comment.
I think we could close this PR and approve the website purge instead. The website purge will solve the link update issue.
|
Superseded by #58 |
Follows the rename in robotiq/robotiq-ros#114 (companion to robotiq/robotiq-ros#143).
.gitmodules:external/robotiq_rosURL →https://github.com/robotiq/robotiq-ros.scripts/external-jobs.js:repoUrl. It must match the links in the ros README, or the version-cut rewrite ofmainlinks to tags stops matching them.docs/website/*.mdx,scripts/generate-tools-table.js: references in prose/comments.Left unchanged: the
robotiq_rosjob key and theexternal/robotiq_rossubmodule path (internal identifiers, not the repo name), and thetest/cut-version.test.jsfixture (it only needs a URL that is not the grippers repo).Merge after robotiq/robotiq-ros#143.
🤖 Generated with Claude Code