Skip to content

Point ROS links and submodule at robotiq/robotiq-ros #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ebarnett3 wants to merge 1 commit into from
+7 −7
Closed

Point ROS links and submodule at robotiq/robotiq-ros #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@
url = https://github.com/robotiq/isaacsim_assets
[submodule "external/robotiq_ros"]
path = external/robotiq_ros
url = https://github.com/robotiq/ros
url = https://github.com/robotiq/robotiq-ros

@mbegin-robotiq mbegin-robotiq Oct 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: once robotiq/robotiq-ros#143 lands, consider bumping the external/robotiq_ros pin (here or via Dependabot). Until then, Latest mixes robotiq-ros URLs (built from relative links) with the README's own robotiq/ros links. Both work thanks to the redirect, so it's cosmetic only.

2 changes: 1 addition & 1 deletion docs/website/how-it-works.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ its own dedicated page (see
[step 4](./adding-a-tool#4-create-the-product-landing-page)). `ROS/`
never gets one of these: there's only ever the one leaf, so its
`index.mdx` is already the real content page — synced from
[robotiq/ros](https://github.com/robotiq/ros) the same way the Tactile
[robotiq/robotiq-ros](https://github.com/robotiq/robotiq-ros) the same way the Tactile
Sensor C++ library page syncs from `tactile_sensors` (see the tree above)
for a Robotiq-maintained integration, hand-authored for a third-party
one.
Expand Down
2 changes: 1 addition & 1 deletion docs/website/quick-reference.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ displayed_sidebar: websiteSidebar
| Synced guide docs folder (verbatim copy of the repo's own `docs/`) | `software-tools/<Product>/<Category>/<Tool>/docs/` |
| Category badge (Libraries / ROS / Simulation / Other) | `![...](.../Category-<Name>-lightgrey)` at the top of each wrapper page |
| Support badge | `![Supported by <Label>](.../Supported_by-<Label>-<color>)`, right after the Category badge |
| ROS page | a single leaf, `software-tools/<Product>/ROS/index.mdx` — no `ROS1`/`ROS2` or per-distro split; `title`/`sidebar_label` literally `ROS`. Synced from [robotiq/ros](https://github.com/robotiq/ros) for Adaptive grippers/Tactile Sensor, hand-authored third-party content for Force Torque Sensor/EPick. Specific supported distros belong in the driver's own repo README, not a page here |
| ROS page | a single leaf, `software-tools/<Product>/ROS/index.mdx` — no `ROS1`/`ROS2` or per-distro split; `title`/`sidebar_label` literally `ROS`. Synced from [robotiq/robotiq-ros](https://github.com/robotiq/robotiq-ros) for Adaptive grippers/Tactile Sensor, hand-authored third-party content for Force Torque Sensor/EPick. Specific supported distros belong in the driver's own repo README, not a page here |
| Product landing pages | `software-tools/<Product>/index.mdx` |
| Draft / not-yet-linked content (never built into a page) | `draft/` at the repo root, outside `docs/` |
| Auto-generated tools tables script | `scripts/generate-tools-table.js` |
Expand Down
2 changes: 1 addition & 1 deletion scripts/external-jobs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ const JOBS = [
]),
]),

...submoduleJobs('robotiq_ros', { repoUrl: 'https://github.com/robotiq/ros', branch: 'main' }, [
...submoduleJobs('robotiq_ros', { repoUrl: 'https://github.com/robotiq/robotiq-ros', branch: 'main' }, [

@mbegin-robotiq mbegin-robotiq Oct 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads-up: this changes what rewriteMainLinksToTag (scripts/cut-version.js:110) matches, and Stable is re-materialized on every build from software-tools-stable.json, which pins adaptive-grippers-ros/tactile-ros to v1.3.0. The README at v1.3.0 (and at the current pin 77ba6fd, and on main) still uses https://github.com/robotiq/ros (5 bare links + one /tree/main), so once this merges none of them get rewritten to /tree/v1.3.0 anymore. Stable silently goes back to pointing at main through the redirect. Merging after robotiq/robotiq-ros#143 doesn't help, since tags are immutable.

Two options:

  1. Add an alias, e.g. repoUrlAliases: ['https://github.com/robotiq/ros'], and have the rewrite match both prefixes (emitting the new URL), plus a case in test/cut-version.test.js. This also covers any future re-cut at an older tag.
  2. Or tag a v1.3.1 on robotiq-ros after #143 and bump software-tools-stable.json in the same PR.

I'd go with 1. Fine as a follow-up.

// One monorepo, one root README (no per-package README) covering both
// packages it ships: grippers/ (Adaptive grippers) and robotiq_tsf/
// (Tactile Sensor) — synced to both products' ROS page. Both
Expand Down
2 changes: 1 addition & 1 deletion scripts/generate-tools-table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
// ROS is the one category capped at a single tool per product — there is
// no per-distro or per-generation split any more, just one `Category-ROS`
// page (software-tools/<product>/ROS/index.mdx), carrying real content
// itself (synced from https://github.com/robotiq/ros for Robotiq-
// itself (synced from https://github.com/robotiq/robotiq-ros for Robotiq-
// maintained products, hand-authored for third-party ones) rather than
// being a container with its own auto-generated landing table. So unlike
// Libraries/Simulation/Other, ROS never gets a dedicated landing page
Expand Down
2 changes: 1 addition & 1 deletion software-tools/Adaptive grippers/ROS/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ sidebar_label: ROS
The source files of the ROS driver, developed and maintained by the
Robotiq team, are available in the following repository:

https://github.com/robotiq/ros
https://github.com/robotiq/robotiq-ros

Below are the related instructions to use this driver.

Expand Down
2 changes: 1 addition & 1 deletion software-tools/Tactile Sensor/ROS/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ sidebar_label: ROS
The source files of the `robotiq_tsf` ROS driver, developed and maintained
by the Robotiq team, are available in the following repository:

https://github.com/robotiq/ros
https://github.com/robotiq/robotiq-ros

Below are the related instructions to use this driver.

Expand Down
Loading