Skip to content

fix(cli): continue rendering after invalid input objects - #40

Merged
scbrown merged 2 commits into
mainfrom
grant/parse-object-recovery
Nov 15, 2026
Merged

scbrown merged 2 commits into
mainfrom
grant/parse-object-recovery

Conversation

@scbrown

@scbrown scbrown commented Nov 12, 2026

Copy link
Copy Markdown
Owner

A balanced object that fails deserialization currently stops stream parsing, hiding every valid object after it. Continue after that known object boundary, retaining a contextual warning with type/name/line. Missing sprite/composition errors now print collected parse diagnostics. Strict mode continues to fail without saving an image.

Closes #38.

Validation: the original CLI reproducer failed before (good reported missing); four CLI regression controls and updated parser recovery control pass. Full cargo test: 2,651 passed, 37 ignored, zero failures across 25 suites; clippy all targets with lsp,wasm and warnings denied passes. HOME guard: 162 paths and 5 UID resources untouched. Existing CLI suites require a verified copy of the built binary at target/debug/pxl when using a routed target directory; initial missing-binary failures were retained and corrected in test setup.

Demo: same fixture against base22d344a and candidate, base exits1/missinggood -> candidate saves4x4red and names the malformed composition. Caption and reproduction, terminal recording, timing. Source-checkout proof, no installed executable changed.

Bead: aegis-sg3

Overlap preflight: c757afa02d2d9c8775bc9115e6e490fd10419894d164fe9176a8fce3e4d8123f

@scbrown scbrown changed the title Continue rendering after invalid input objects fix(cli): continue rendering after invalid input objects Nov 14, 2026
@scbrown
scbrown merged commit 3822ace into main Nov 15, 2026
16 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An object that fails to parse hides every object after it; render reports 'not found' without naming the parse error

1 participant