Repository navigation
P1: Mark committed graph reconciliation failures as reload-required - #228
Merged
philipgreat merged 2 commits intoOct 21, 2026
Conversation
Contributor
Author
|
Exact candidate head 628991a: local affected reactor |
This was referenced Oct 18, 2026
philipgreat
merged commit Oct 21, 2026
f61d8bd
into
fix/committed-audit-postcommit-java
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on audit-delivery draft #226; not for direct merge to main.
A test-only GraphEntity setter fault after SQLite transaction return reproduced an ordinary save error despite a committed business row and Outbox event. This candidate returns a dedicated committed/reload-required error and marks only the participating EntityMutationLedger unsafe for another save; an independent graph in the same UserContext still saves.
At head 092e483, post-commit reconciliation failure no longer suppresses independent audit delivery. Audit events take the authoritative committed version from the provider result, not a partially reconciled entity. If audit delivery also fails, its sanitized failure is suppressed on the reconciliation exception. SQLite tests cover root and child audit attempts, both-failure classification, persisted row/Outbox, and rejection of same-graph retries.
Local verification: GraphTraceSqliteTest 36/36 and the full affected teaql-runtime + teaql-sqlite Maven reactor passed. The feature-targeted Example Gate and CI-only main-targeted #230 passed all five named gates at the exact 092e483 head; #230 was closed without merge. This is a controlled fault-injection boundary, not a claim of normal generated-entity failure or full P1 acceptance. Human review, audit-delivery API choice, and formal #216 integration remain open.