Repository navigation
feat: map the Organizations-area response members from the 1.74.0 gap report - #417
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 9 |
🟢 Coverage 100.00% diff coverage · +0.64% coverage variation
Metric Results Coverage variation ✅ +0.64% coverage variation Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (9d400ac) 7839 2719 34.69% Head commit (ffe8209) 7838 (-1) 2769 (+50) 35.33% (+0.64%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#417) 3 3 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This was referenced Sep 9, 2026
Merged
danielabbatt
force-pushed
the
fix/response-shape-defects
branch
from
September 29, 2026 12:15
8536621 to
965af9f
Compare
danielabbatt
force-pushed
the
feat/map-organizations-members
branch
from
September 29, 2026 12:15
469bd04 to
7b01747
Compare
danielabbatt
force-pushed
the
fix/response-shape-defects
branch
from
September 29, 2026 12:43
965af9f to
ad61aa9
Compare
danielabbatt
force-pushed
the
feat/map-organizations-members
branch
from
September 29, 2026 12:43
7b01747 to
3d0d624
Compare
danielabbatt
force-pushed
the
fix/response-shape-defects
branch
from
September 29, 2026 12:52
ad61aa9 to
dcef70e
Compare
danielabbatt
force-pushed
the
feat/map-organizations-members
branch
from
September 29, 2026 12:52
3d0d624 to
6a7aa02
Compare
… report Thirty members the v1.74.0 spec documents that the models lacked, the first of the per-area batches. Scalars on eleven existing classes, and nested objects backed by six new classes (NextUpgradePredownload, NetworkStatusSummaryGroup, NetworkStatusSummaryPermissions, OrganizationAdaptivePolicyOverviewLimits, OrganizationAssuranceAlertsOverviewByTypeItemNetwork, WebhookAlertTypeExample). Read-only except where the spec puts the member on a request body. Three models in the area never matched the API and are corrected: OrganizationAssuranceAlertsOverviewByTypeItem carried a copy of the by-network item's members; it now has the documented shape and the old SeverityCount type is [Obsolete]. WebhookAlertType had the example payload's fields flattened onto the alert type; the API sends them under "example". They are [Obsolete] at the top level and available on Example. OrganizationDevicesSyslogServersRolesByNetworkItem mapped "availableRoles"; the API sends "available". C# name unchanged. OrganizationsMemberTests covers the new members and the corrected shapes.
danielabbatt
force-pushed
the
fix/response-shape-defects
branch
from
September 29, 2026 12:56
dcef70e to
9d400ac
Compare
danielabbatt
force-pushed
the
feat/map-organizations-members
branch
from
September 29, 2026 12:56
6a7aa02 to
ffe8209
Compare
danielabbatt
changed the base branch from
fix/response-shape-defects
to
main
September 29, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #416, in the chain that starts at #415
Base is
fix/response-shape-defects. Merge #415 and #416 first (merge commits), then retarget this tomain. Changelog label1.74.7assumes that order.What
The first per-area batch from
gap-report-v1.74.0.md: 30 Organizations-area members the spec documents that the models lacked, across 17 classes. Types and read/write access come from the spec; XML docs are the spec descriptions.LoginSecurity.EnforceLockedIpSessions,NextUpgrade.Strategy,SamlIdp.SsoLoginUrl/.VisionConsumerUrl,OrganizationDevice.Imeiand othersFirmwareProducts.CampusGateway, bothSwitchCatalyst), 6 need new classesNextUpgradePredownload,NetworkStatusSummaryGroup,NetworkStatusSummaryPermissions,OrganizationAdaptivePolicyOverviewLimits,OrganizationAssuranceAlertsOverviewByTypeItemNetwork,WebhookAlertTypeExampleNextUpgrade.Strategyis astring?rather than an enum (minimizeClientDowntime/minimizeUpgradeTime) so an unlisted value can't break deserialization.Three corrections, not just additions
The diff surfaced three models in this area that never matched the API. Reading their old members always gave defaults, so changing them is breaking only in the type-system sense:
OrganizationAssuranceAlertsOverviewByTypeItemwas a copy of the by-network item (AlertCount,NetworkId,NetworkName,SeverityCounts). The API sendstype,categoryType,severity,count,networkCount,networks,deviceTypes,deviceTags,lastAlertedAt,lastResolvedAt. Rebuilt to that;OrganizationAssuranceAlertsOverviewByTypeItemSeverityCountis[Obsolete].WebhookAlertTypehad the example payload's 19 fields flattened onto the alert type. The API sends{alertTypeId, alertType, example}. The flattened ones are[Obsolete]pointing at the newExample, which also carries five fields they never had.OrganizationDevicesSyslogServersRolesByNetworkItem.AvailableRolesmappedavailableRoles; the API sendsavailable. DataMember fixed, C# name kept.Verification
All 18 edited model files kept their BOM state and CRLF. No code outside
Datareferenced the corrected members.Next
Remaining areas in the report, largest first: SM (27), Appliance (25), Wireless (19), General (10), Camera (8), CellularGateway (7), Switch (7), Sensor (6), LiveTools (2), Licensing (1).