Repository navigation
Screen extensions registry - #16
Merged
jayjfletcher merged 34 commits intoOct 30, 2026
Merged
Conversation
…ions, screen and resolution (salvaged) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ions, screen and resolution Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…om Atrium Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nts and the test-host screen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…own screens Declares atrium.dashboard, atrium.named-dashboard, atrium.dashboard-widget, atrium.settings and atrium.settings-panel with Screen::standard() and renders the tab bar, the open registered tab's panel and their slots per criterion 15. row.actions on atrium.settings awaits a decision: a settings panel is not a model. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…own screens Per D-032, all five Atrium screens declare a Gate access() closure, so permission() extensions show when the Gate allows them. D-031 (row.actions per settings panel row) is held: the stand-in model would fail the lifecycle events arch test, which needs a decision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…own screens Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…own screens Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… layout matrix Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… layout matrix Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…chitecture and build Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…chitecture and build Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 30, 2026
jayjfletcher
deleted the
ring-master/2026-10-29-2037-screen-extensions-registry
branch
November 11, 2026 04:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk: high
What changed
Domains/Screens:ScreenExtensionsregistry, a singleton reached throughAtrium::screens()TabDefinitionandSectionDefinitionScreen, withstandard()slots:header.actions,before,after,aside, and the row slotrow.actionsResolvedScreenScreenVisibility*and{package}.*x-atrium::screen-tabs,screen-tab-panelandscreen-sectionscomponentsTesting\ResetsScreenExtensionstraitaccess()check: the dashboard, the named dashboard, widget detail, the settings index (with arow.actionsslot on each panel row) and the settings panel.history/{package}route andHistoryControllerx-atrium::audit-trailandx-atrium::audit.*Plugin::historyNavItem()Why
This makes "register it from your own package" the only way to add tabs and sections to any screen, so host packages stop checking whether other packages are installed (D-017: no package knows another; integrations go through config). It generalises Roster's registered tabs (Roster PR #5).
Look at
src/Domains/Screens/Services/ScreenExtensions.php: registration, the duplicate rules by environment (D-022), and exact/pkg.*/*precedence (D-023, D-028).src/Domains/Screens/Services/ScreenVisibility.php: the per-request memo keyed by morph class plus key or the model itself. Visibility answers must never leak across viewers.resources/views/components/screen-sections.blade.php: failure isolation. It snapshots and restores the view factory's state so that a throwing section can't break the page (D-015).src/Domains/Settings/Data/SettingsPanelRow.php: the unsaved stand-in that carries each settings panel row (D-031, D-033).Tested
composer test: phpstan 0 errors, pint, 100% type coverage, pest 589/589.composer test:browser: 46/46, including the 24 theme × layout × mode cases. The gate didn't run this suite; I ran it by hand after the job escalated.npm run build:css:public/atrium.cssis unchanged, so the committed file is current.Risks
historyNavItem()are gone. Every host that uses them breaks until its own spec lands (see Breaks). Merge as a group: Atrium, Keen, then the hosts (D-009).Acceptance criteria and proving tests (round 3 gate)
Unit/Screens/ScreenExtensionsTest,Feature/Screens/ResolveScreenTestUnit/Screens/TabDefinitionTest,SectionDefinitionTestUnit/Screens/ScreenExtensionsTest,ResolveScreenTest(all-digit keys)ResolveScreenTest(duplicates by environment, precedence)Unit/Screens/ScreenExtensionsTest(snapshot/restore/flush),Feature/Screens/ResetsScreenExtensionsTestUnit/Screens/ScreenTestResolveScreenTestFeature/Screens/VisibilityTestFeature/Screens/EvaluationOrderTestFeature/Screens/RowSlotsTestFeature/Screens/WildcardRenderingTestFeature/Screens/FailureIsolationTestFeature/Screens/ScreenTabsComponentTestFeature/Screens/ScreenSectionsComponentTestFeature/Screens/OpenRegisteredTabTestFeature/Screens/ScreenStylesTest. Afternpm run build:css,public/atrium.cssis unchanged.17, 18.
tests/Browser/ScreenExtensionsTest.php: a dataset over 6 themes × 2 layouts × light/dark.composer test:browserpasses 46/46.Feature/Screens/AtriumScreensTestFeature/HistoryRemovedTest,Feature/DocsTest,ArchTestFeature/DocsTesttests/ArchTest.phpNits remaining: none.
Known issues (accepted)
Breaks
Removing the history page and audit components breaks these packages until their own specs land. Merge as a group: Atrium, Keen, then the hosts (D-009).
x-atrium::audit*,historyNavItem()oratrium.historySpec:
docs/agent/specs/2026-10-29-2037-screen-extensions-registry/. This is the first spec of the Guardian and screen-extensions initiative, and the other specs build on it.🤖 Generated with Claude Code