Repository navigation
[build-tools] Add serve-sim Simulator startup helpers - #4605
Conversation
f9d9bb7 to
02df7c4
Compare
|
Codex extracted the startup prerequisite under Gabe's direction. Gabe reviewed the implementation through #4601. The test-only follow-up at 5214b04 adds eight cases for startup inputs, guard logging, WebSocket failures and staging cleanup, and improves existing authentication/dedup assertions. Runtime code is unchanged; human inspection of the added tests is pending. Local added-line coverage rose from 93.0% to 99.3% (142/143). The foundation's 163 focused tests and the tip's 294 startup/action tests pass, along with TypeScript, lint and formatting. Opus review found a weak duplicate-relay assertion; it now fails when protection is removed, and the final review is clean. — Codex |
02df7c4 to
e950d9e
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gwdp/serve-sim-argent-logs #4605 +/- ##
==============================================================
+ Coverage 74.48% 74.55% +0.08%
==============================================================
Files 1029 1032 +3
Lines 50391 50538 +147
Branches 10893 10929 +36
==============================================================
+ Hits 37527 37673 +146
- Misses 11874 11875 +1
Partials 990 990 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e950d9e to
793615f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
eas-cli now uses changesets for changelogs (#4580). The required "Check for a changeset" check fails on PRs that edit To update this PR:
The release adds the PR link and the author to the entry. If this PR needs no changelog entry, revert the |
|
Rebased this layer onto Validation: focused build-tools tests, changeset validation, changed-file lint/format and build-tools typecheck passed. No new native or hosted acceptance was run for this restack. Published head: — Codex |
a84daa6 to
5436a79
Compare
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
5436a79 to
6026bec
Compare
|
✅ Thank you for adding a changeset! |
Why
Share the Simulator and app-control code needed for serve-sim to own startup.
How
iosAppArtifact.ts, separately from serve-sim requests. Generic EAS boot/install functions stay unchanged; no session caller uses the new startup helpers here. Existing guard-log polling starts earlier during guard setup.Test Plan
ff255a5. Fresh CI and Devin review are pending for this test-only follow-up.Startup benchmark
These helpers have no session caller in this PR. The table measures the completed activation stack, rather than a speedup from merging this foundation alone.
Codex measured four alternating pairs per type on an initialized iPhone 17 Pro Simulator (iOS 26.4, Tart 6 CPU / 8 GiB), starting shut down with the app absent and packages cached. Timing runs from worker entry to local session reporting, using real controllers and native boot/install/launch with loopback cloud adapters.
This compares the completed startup stack
e0b7462against main4aca8b1, with the same pinned local serve-sim #260 build; it does not isolate this PR's contribution. Hosted dispatch and first browser frame were not measured.Savings are the median of paired differences, not the difference between the two arm medians. Agent-device varied from 1.51s slower to 5.29s faster; it has no consistent speedup in this sample. Argent and Appium were faster in all four pairs.
Authorship and LLM use
Gabe wrote the initial implementation and guided the design. Codex extracted the helpers and separated app metadata, session preparation and serve-sim requests. AI review moved orchestration tests and docs beside their first caller. Gabe reviewed the implementation through #4601, including this prerequisite. Codex added this test-only follow-up and iterated with Opus review. Gabe reviewed the added tests.