Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gwdp/serve-sim-startup-implementation #4601 +/- ##
=========================================================================
+ Coverage 74.55% 74.60% +0.05%
=========================================================================
Files 1032 1032
Lines 50538 50642 +104
Branches 10929 10969 +40
=========================================================================
+ Hits 37673 37774 +101
- Misses 11875 11878 +3
Partials 990 990 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1472479 to
bd08790
Compare
This comment has been minimized.
This comment has been minimized.
1052c54 to
d9c4341
Compare
|
Codex implemented and simplified the startup path under Gabe's direction, including the readiness-failure fix. Gabe's review through eb9afe1 predates that fix and the new coverage tests. Restacked at fb05693 to inherit #4605's test-only follow-up. Range-diff confirms this layer's patch and all runtime code are unchanged. The tip's 294 startup/action tests and TypeScript check pass; new CI is pending. No new device, hosted or human-review evidence is claimed. Ready for Szymon (szdziedzic) as reviewer, with no assignee, as Gabe requested. The description retains the Universe server/www activation boundary and separately documented shared-host changes. — Codex |
03b932f to
3967c06
Compare
d641e4a to
eb9afe1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b5c7013 to
fb05693
Compare
|
eas-cli now uses changesets for changelogs (#4580). The required "Check for a changeset" check fails on PRs that edit To update this PR:
The release adds the PR link and the author to the entry. If this PR needs no changelog entry, revert the |
|
Rebased this layer onto Validation: focused build-tools tests, changeset validation, changed-file lint/format and build-tools typecheck passed. No new native or hosted acceptance was run for this restack. Published head: — Codex |
2834398 to
038cf0f
Compare
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
038cf0f to
c1588a3
Compare
|
Rebased onto current main and resolved the shared-host conflict, preserving Android preview authentication and the iOS startup token/custom state directory. The upper stack is restacked too. Local validation: 355 focused tests, build-tools typecheck, resolved-file lint/format, and independent source review passed. Fresh CI is pending. — Codex |
|
✅ Thank you for adding a changeset! |
Why
Give web preview one owner for starting the Simulator and app, including the egress guard.
How
server/wwwsends the new workflow inputs; merging this PR alone does not move boot/install/launch ownership. Existing www-generated workflows retain their boot/install steps and serve-sim launch flags; Android keeps its existing device-startup path.Shared host changes also make web-preview startup cancellable, explicitly set iOS temporary/state directories and refine readiness errors. Xcode selection happens before input validation.
Release serve-sim with the app-control API before deploying the worker, then enable the new workflow inputs in Universe
server/www.Test Plan
b5c7013, including Node 20/22/24 and the egress-guard check. The earlier Devin review had a successful status; its final report was still pending when checked.Earlier web-preview timing
d13f4ed5This is the earlier local Tart result, from worker entry to session reporting with a stopped Simulator, cached packages and loopback cloud adapters. It is not a measurement of the current head. The new controlled comparison covered agent-device, Argent and Appium; web preview has not been remeasured. Hosted dispatch and worker allocation were not measured.
Authorship and LLM use
Gabe wrote the initial implementation and guided the design. Codex implemented and split the changes. AI review led to fixes for startup order and cleanup. Gabe reviewed the final code through
eb9afe1, including this web-preview layer. Fresh Devin review then found that readiness failure could leave startup waiting for control state. Codex fixed failure propagation and added regressions for control-state and download waits. Gabe reviewed this follow-up.