Repository navigation
[15/17] DLA TopK and dtype compatibility - #2967
Draft
mgohil-png wants to merge 1 commit into
Draft
mgohil-png wants to merge 1 commit into
mgohil-png wants to merge 1 commit into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This was referenced Oct 23, 2026
mgohil-png
added this pull request to stack #2970
October 23, 2026 06:30
Contributor
Author
|
@coderabbitai full review |
Contributor
|
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
from
October 23, 2026 08:49
7af9e1c to
6489713
Compare
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
from
October 23, 2026 08:54
6489713 to
c12468f
Compare
Contributor
|
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
from
October 23, 2026 10:18
c12468f to
9c80569
Compare
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
from
October 23, 2026 10:32
9c80569 to
378715f
Compare
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
2 times, most recently
from
October 23, 2026 11:46
b4069b8 to
9857bcb
Compare
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
from
October 23, 2026 12:10
9857bcb to
752dac1
Compare
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
from
October 23, 2026 12:28
752dac1 to
d56d4d3
Compare
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
from
October 23, 2026 12:42
d56d4d3 to
3cdcc10
Compare
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
2 times, most recently
from
October 23, 2026 13:22
5903522 to
e3d424c
Compare
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
from
October 23, 2026 13:42
e3d424c to
221de94
Compare
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
2 times, most recently
from
October 23, 2026 15:04
1300d38 to
7ec0e18
Compare
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
from
October 23, 2026 15:22
7ec0e18 to
82885c5
Compare
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
from
October 23, 2026 15:39
82885c5 to
8ac0ba5
Compare
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
from
October 23, 2026 16:49
8ac0ba5 to
da7137c
Compare
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
from
October 23, 2026 17:06
da7137c to
451cb98
Compare
Signed-off-by: mgohil <mgohil@nvidia.com>
mgohil-png
force-pushed
the
dla/review-15-dla-topk-and-dtype-compatibility
branch
from
October 23, 2026 17:25
451cb98 to
c11fc95
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: new feature
Simplify the supported TopK/Cast/Reshape/Tile/GatherElements chain, handle eligible integer Unsqueeze inputs, and provide standalone InstanceNormalization channel-layout compatibility. Preserve unsupported/shared patterns and register the ordered TopK and Unsqueeze stages.
Part 15/17. Depends on part 14; merge from the bottom of the stack upward.
Usage
This is an internal pass; the public pipeline is registered in part 16.
Testing
Tests ran with Hugging Face offline mode and without the repository-wide conftest/addopts; test-module fixtures still ran. GPU execution and DLA compilation were not run. The final stacked branch also passed the combined focused suite: 317 passed, 2 warnings.
Before your PR is "Ready for review"
Additional Information
Base branch:
dla/review-14-dla-boolean-and-comparison-rewrites. Review this slice against that branch; subsequent slices are reviewed separately.Merge order: PR1 (merged) → Part 2/17 → Part 3/17 → Part 4/17 → Part 5/17 → Part 6/17 → Part 7/17 → Part 8/17 → Part 9/17 → Part 10/17 → Part 11/17 → Part 12/17 → Part 13/17 → Part 14/17 → Part 15/17 → Part 16/17 → Part 17/17