Repository navigation
[16/17] DLA public integration and reshape cleanup - #2968
Draft
mgohil-png wants to merge 1 commit into
Draft
mgohil-png wants to merge 1 commit into
mgohil-png wants to merge 1 commit into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This was referenced Oct 23, 2026
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This was referenced Oct 23, 2026
mgohil-png
added this pull request to stack #2970
October 23, 2026 06:30
Contributor
Author
|
@coderabbitai full review |
Contributor
|
mgohil-png
force-pushed
the
dla/review-16-dla-public-integration-and-reshape-cleanup
branch
from
October 23, 2026 08:49
2b85ef4 to
83bf56d
Compare
mgohil-png
force-pushed
the
dla/review-16-dla-public-integration-and-reshape-cleanup
branch
from
October 23, 2026 08:54
83bf56d to
3e065d4
Compare
Contributor
|
mgohil-png
force-pushed
the
dla/review-16-dla-public-integration-and-reshape-cleanup
branch
2 times, most recently
from
October 23, 2026 10:32
626fadb to
67dc3a9
Compare
mgohil-png
force-pushed
the
dla/review-16-dla-public-integration-and-reshape-cleanup
branch
from
October 23, 2026 10:54
67dc3a9 to
b10ae90
Compare
mgohil-png
force-pushed
the
dla/review-16-dla-public-integration-and-reshape-cleanup
branch
2 times, most recently
from
October 23, 2026 12:10
70cd166 to
49f96ba
Compare
mgohil-png
force-pushed
the
dla/review-16-dla-public-integration-and-reshape-cleanup
branch
from
October 23, 2026 12:28
49f96ba to
fbeabac
Compare
mgohil-png
force-pushed
the
dla/review-16-dla-public-integration-and-reshape-cleanup
branch
from
October 23, 2026 12:42
fbeabac to
d890ca9
Compare
mgohil-png
force-pushed
the
dla/review-16-dla-public-integration-and-reshape-cleanup
branch
from
October 23, 2026 13:03
d890ca9 to
b9cf201
Compare
mgohil-png
force-pushed
the
dla/review-16-dla-public-integration-and-reshape-cleanup
branch
from
October 23, 2026 13:22
b9cf201 to
78b1efd
Compare
mgohil-png
force-pushed
the
dla/review-16-dla-public-integration-and-reshape-cleanup
branch
2 times, most recently
from
October 23, 2026 14:22
74cd72a to
ac2994d
Compare
mgohil-png
force-pushed
the
dla/review-16-dla-public-integration-and-reshape-cleanup
branch
from
October 23, 2026 15:04
ac2994d to
02fe9a2
Compare
mgohil-png
force-pushed
the
dla/review-16-dla-public-integration-and-reshape-cleanup
branch
from
October 23, 2026 15:22
02fe9a2 to
61b253b
Compare
mgohil-png
force-pushed
the
dla/review-16-dla-public-integration-and-reshape-cleanup
branch
from
October 23, 2026 15:39
61b253b to
11b937c
Compare
mgohil-png
force-pushed
the
dla/review-16-dla-public-integration-and-reshape-cleanup
branch
2 times, most recently
from
October 23, 2026 17:06
d49f45a to
7fb3900
Compare
Signed-off-by: mgohil <mgohil@nvidia.com>
mgohil-png
force-pushed
the
dla/review-16-dla-public-integration-and-reshape-cleanup
branch
from
October 23, 2026 17:25
7fb3900 to
efbe9a4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: new feature
Expose the ordered DLA pipeline as make_dla_compatible through the Python API, surgery registry, and CLI. Load external weights, apply each transform in sequence, infer shapes at defined boundaries, reorder and check the final graph, and save through the shared ONNX helper. Add final reshape cleanup and controls for QDQ removal and external output weights. The supported transformations are not exhaustive; additional passes can be needed for other model patterns.
Part 16/17. Depends on part 15; merge from the bottom of the stack upward.
Usage
Testing
Tests ran with Hugging Face offline mode and without the repository-wide conftest/addopts; test-module fixtures still ran. GPU execution and DLA compilation were not run. The final stacked branch also passed the combined focused suite: 317 passed, 2 warnings.
Before your PR is "Ready for review"
Additional Information
Base branch:
dla/review-15-dla-topk-and-dtype-compatibility. Review this slice against that branch; subsequent slices are reviewed separately.Merge order: PR1 (merged) → Part 2/17 → Part 3/17 → Part 4/17 → Part 5/17 → Part 6/17 → Part 7/17 → Part 8/17 → Part 9/17 → Part 10/17 → Part 11/17 → Part 12/17 → Part 13/17 → Part 14/17 → Part 15/17 → Part 16/17 → Part 17/17